Skip to content

Security hardening, input validation, memory-safety, and key zeroization fixes#438

Merged
padelsbach merged 43 commits into
wolfSSL:masterfrom
aidangarske:fenrir-medium-batch
Jul 13, 2026
Merged

Security hardening, input validation, memory-safety, and key zeroization fixes#438
padelsbach merged 43 commits into
wolfSSL:masterfrom
aidangarske:fenrir-medium-batch

Conversation

@aidangarske

@aidangarske aidangarske commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member 
F-4824, F-5921, F-4292, F-4291, F-5198, F-5925, F-4699, F-5918, F-5913, F-4289, F-5866, F-5805, F-4698,
F-4384, F-4937, F-4826, F-4938, F-4940, F-5924, F-5923, F-5544, F-6682, F-5185, F-5184, F-5922, F-6670,
F-4941

CI:ALL did fully run and pass on this

aidangarske added 27 commits July 9, 2026 19:09
@aidangarske
F-4941 - Reject PBKDF2 iteration count above INT_MAX
e5214e0
@aidangarske
F-6670 - Encode both bytes of RSA-PSS salt length >= 256
e3bc98a
@aidangarske
F-5922 - Commit ECDSA digest type only after validation
d163760
@aidangarske
F-5184 - Reject ECC private scalar outside [1, n-1] on import
f2e2c2d
@aidangarske
F-5185 - Validate explicit DH domain parameters in param check
ef42fc0
@aidangarske
F-6682 - Zeroize HMAC context on free
350082a
@aidangarske
F-5544 - Zeroize PBKDF1 key in PEM encrypt fallback
84d51c8
@aidangarske
F-5923 - Reset CCM TLS AAD length like the GCM path
3cbb1d8
@aidangarske
F-5924 - Clear TLS ETM output length on bad padding
27eda91
@aidangarske
F-4940 - Cap PEM password callback length to buffer size
ba77631
@aidangarske
F-4938 - Cap EPKI decode password length to buffer size
a65d3bf
@aidangarske
F-4826 - Cap encrypt-key password length to buffer size
5fb013f
@aidangarske
F-4937 - Cap RSA PKCS8 decode password length to buffer size
f7358e5
@aidangarske
F-4384 - Guard AES key wrap lengths against word32 truncation
d144a3a
@aidangarske
F-4698 - Cap DER BIO read accumulator against word32 overflow
7625364
@aidangarske
F-5805 - Pass original dispatch table to OSSL_LIB_CTX_new_child
91cdeae
@aidangarske
F-5866 - Re-init urandom mutex in forked child
b1ae85e
@aidangarske
F-4289 - Reject zero-length X25519/X448 private key import
d9009e0
@aidangarske
F-5913 - Bound ECC group name compare to param length
cb74265
@aidangarske
F-5918 - Bound DH group name compare and fix utf8 copy guard
6294f5d
@aidangarske
F-4699 - Reject truncated PEM before header detection
e24e797
@aidangarske
F-5925 - Pass record base pointer to TLS CBC decrypt
4491ee7
@aidangarske
F-5198 - Guard DES3 TLS record length before padding strip
d58dab1
@aidangarske
F-4291 - Reject HMAC key set without a digest
779e3b1
@aidangarske
F-4292 - Report KDF exchange dup as unsupported instead of empty
858a695
@aidangarske
F-5921 - Validate PKCS12 KDF diversifier id range
8ec8493
@aidangarske
F-4824 - Guard legacy PKCS8 DER-to-PEM size against word32 overflow
51ae87b
Copilot AI review requested due to automatic review settings July 10, 2026 04:35
@aidangarske aidangarske changed the title Fenrir Medium findings: memory-safety, validation, and hardening fixes Security hardening: memory-safety, input validation, and zeroization fixes Jul 10, 2026
@aidangarske aidangarske self-assigned this Jul 10, 2026
@aidangarske aidangarske added the ci:all PR OSP toggle: run all label Jul 10, 2026
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 13, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #438

Scan targets checked: wolfprovider-bugs, wolfprovider-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread src/wp_ecc_kmgmt.c Outdated
Comment thread test/test_tls_cbc.c
padelsbach
padelsbach reviewed Jul 13, 2026
View reviewed changes

@padelsbach padelsbach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements. A few minor questions

Comment thread src/wp_des.c Outdated
Comment thread test/test_dh.c Outdated
Comment thread test/test_hkdf.c
Comment thread src/wp_ecc_kmgmt.c Outdated
Comment thread src/wp_des.c
@aidangarske aidangarske requested a review from padelsbach July 13, 2026 21:35
padelsbach
padelsbach reviewed Jul 13, 2026
View reviewed changes
Comment thread test/test_tls_cbc.c Outdated
Comment thread test/test_tls_cbc.c
Comment thread src/wp_aes_wrap.c Outdated
@padelsbach padelsbach assigned aidangarske and unassigned padelsbach Jul 13, 2026
@aidangarske aidangarske requested a review from padelsbach July 13, 2026 23:12
@padelsbach padelsbach merged commit f7ad5e6 into wolfSSL:master Jul 13, 2026
71 checks passed
@aidangarske aidangarske deleted the fenrir-medium-batch branch July 13, 2026 23:14
@padelsbach padelsbach mentioned this pull request Jul 13, 2026
Merged
aidangarske added a commit to aidangarske/wolfProvider that referenced this pull request Jul 13, 2026
@aidangarske
Merge origin/master into fenrir-low-info-batch (resolve wolfSSL#438 o…
0224cbe 
…verlap)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left review comments
@padelsbach padelsbach padelsbach approved these changes
@ColtonWilley ColtonWilley Awaiting requested review from ColtonWilley

Assignees

@padelsbach padelsbach

Labels

ci:all PR OSP toggle: run all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aidangarske @padelsbach @wolfSSL-Fenrir-bot