Throw correct InvalidParameterException from Cipher.init() on unsupported mode#143
Merged
rlm2002 merged 1 commit intowolfSSL:masterfrom Aug 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect exception type in the WolfCrypt JCE provider's Cipher implementation. When an invalid mode is passed to Cipher.init(), the code now throws InvalidParameterException instead of InvalidKeyException to comply with JCE specification expectations.
- Changed exception type from
InvalidKeyExceptiontoInvalidParameterExceptioninwolfCryptSetDirection()method - Added test case to verify the correct exception is thrown for invalid cipher modes
- Added necessary import for
InvalidParameterExceptionin both files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/wolfssl/provider/jce/WolfCryptCipher.java | Updated exception type and added import for InvalidParameterException |
| src/test/java/com/wolfssl/provider/jce/test/WolfCryptCipherTest.java | Added test case and import to verify correct exception behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
27bac22 to
4dcda6f
Compare
rlm2002
previously approved these changes
Aug 21, 2025
…de is unsupported or incorrect
4dcda6f to
6f2434a
Compare
rlm2002
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the exception type thrown by
Cipher.init()if an unsupported or incorrect mode is passed in. It was previouslyInvalidKeyException, but should beInvalidParameterExceptionto match what consumers will expect.This fixes the OpenJDK SunJCE test:
crypto/Cipher/TestCipherMode.java