Polish ESP32 SSH to UART, Address issue #5#6
Merged
ejohnstown merged 2 commits intowolfSSL:mainfrom Aug 8, 2024
Merged
Conversation
Closed
ejohnstown
previously approved these changes
Aug 8, 2024
ejohnstown
approved these changes
Aug 8, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh-examples
that referenced
this pull request
Oct 18, 2024
Polish ESP32 SSH to UART, Address issue wolfSSL#5
jefferyq2
pushed a commit
to jefferyq2/wolfssh-examples
that referenced
this pull request
Oct 18, 2024
Polish ESP32 SSH to UART, Address issue wolfSSL#5
jefferyq2
pushed a commit
to jefferyq2/wolfssh-examples
that referenced
this pull request
Oct 18, 2024
Polish ESP32 SSH to UART, Address issue wolfSSL#5
jefferyq2
pushed a commit
to jefferyq2/wolfssh-examples
that referenced
this pull request
Oct 18, 2024
Polish ESP32 SSH to UART, Address issue wolfSSL#5
jefferyq2
pushed a commit
to jefferyq2/wolfssh-examples
that referenced
this pull request
Oct 18, 2024
Polish ESP32 SSH to UART, Address issue wolfSSL#5
jefferyq2
added a commit
to jefferyq2/wolfssh-examples
that referenced
this pull request
Oct 18, 2024
Polish ESP32 SSH to UART, Address issue wolfSSL#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds support for the ESP32-C3 and addresses other issues found in #5
I've confirmed code works for both the in-place
wolfsslandwolfsshcomponents, as well as using the Managed Components.The respective component
CMakeLists.txtfiles have been updated to more robustly support finding source code in parent directories, and / or by explicitly assigningWOLFSSL_ROOTand/orWOLFSSH_ROOTas desired.Various other files have also been cleaned up for line length, spelling, and other minor improvements.
New project files for VisualGDB using EDP-IDF v5.2 have also been added.