Skip to content

Harden wolfsshd auth tests#1115

Open
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:fix-searchforpubkey-unittest-proto
Open

Harden wolfsshd auth tests#1115
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:fix-searchforpubkey-unittest-proto

Conversation

@stenslae

@stenslae stenslae commented Jul 21, 2026

Copy link
Copy Markdown
Member

test_AuthSetGroups_ relied on the host having a real sshd system user. Now mocks wsshd_getpwnam_cb instead.

@stenslae stenslae self-assigned this Jul 21, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1115

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread apps/wolfsshd/test/test_configuration.c
Comment thread apps/wolfsshd/test/test_configuration.c
@stenslae
stenslae force-pushed the fix-searchforpubkey-unittest-proto branch from 75f9b51 to 78ec5d2 Compare July 21, 2026 22:00

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1115

Scan targets checked: wolfssh-bugs, wolfssh-src

No new issues found in the changed files. ✅

@stenslae stenslae assigned wolfSSL-Bot and unassigned stenslae Jul 21, 2026
@stenslae
stenslae force-pushed the fix-searchforpubkey-unittest-proto branch from 78ec5d2 to e71836b Compare July 22, 2026 15:52
@stenslae stenslae changed the title Harden wolfsshd auth tests and guard NO_FILESYSTEM SCP receive against zero-size writes Harden wolfsshd auth tests Jul 22, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1115

Scan targets checked: wolfssh-bugs, wolfssh-src

No new issues found in the changed files. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants