fix for zephyr time include - #1144
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Zephyr port header handling in wolfSSH to ensure struct timeval is available via an explicit Zephyr POSIX time include, avoiding reliance on transitive includes affected by recent wolfSSL wc_port.h changes.
Changes:
- Add an explicit include of
<zephyr/posix/sys/time.h>for Zephyr builds whenCONFIG_POSIX_APIis enabled and/or when building on Zephyr >= 4.1.0. - Replace the older version-only comment/guard with a clearer rationale tied to transitive-include changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for header include after wolfssl wc_port.h changes from wolfSSL/wolfssl#10983