Skip to content

Deduplication and type checking - #1159

Open
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:followup-review-findings
Open

Deduplication and type checking#1159
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:followup-review-findings

Conversation

@stenslae

Copy link
Copy Markdown
Member
  • Added authorized_key type checking extract the embedded key type directly from the SSH wire-format blob rather than using wolfSSH_QueryKey().
  • Added a makeKey function pointer to CompositeTradOps.
  • Deduplicated ECDSA Encoding
  • Introduced WOLFSSH_MLDSA_COMPOSITE_ID_CASES for redundant switch cases.
  • Centralized maximum public key sizing behind a new WOLFSSH_MLDSA_MAX_PUB_KEY_SZ macro
  • Switched to dynamically allocating MlDsaKey and large public key buffers in wolfSSH_MakeMlDsaCompositeKey() and GetOpenSshKeyMlDsaComposite() when WOLFSSH_SMALL_STACK is defined.
  • Added test coverage

@stenslae stenslae self-assigned this Aug 11, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread src/internal.c
Comment thread src/ossh.c
Comment thread apps/wolfsshd/test/test_configuration.c
Comment thread apps/wolfsshd/auth.c
Comment thread apps/wolfsshd/test/test_configuration.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants