Skip to content

Use wolfSSL API functions; not private ones.#343

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
anhu:wc_ParseCert
Nov 3, 2022
Merged

Use wolfSSL API functions; not private ones.#343
dgarske merged 1 commit intowolfSSL:masterfrom
anhu:wc_ParseCert

Conversation

@anhu
Copy link
Copy Markdown
Member

@anhu anhu commented Nov 2, 2022

No description provided.

@anhu anhu requested a review from dgarske November 2, 2022 21:37
Comment thread pq/sphincs_sign_verify.c
if (ret == 0) {
InitDecodedCert(&decodedCert, cert_der_buf, cert_der_len, 0);
ret = ParseCert(&decodedCert, CERT_TYPE, NO_VERIFY, NULL);
wc_InitDecodedCert(&decodedCert, cert_der_buf, cert_der_len, 0);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: These API's were added in wolfSSL/wolfssl#4645 and are in v5.1.0 or later.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we had to use a macro to expose those private functions. The build macro can be found in asn.h. I can’t recall the name offhand.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgarske dgarske merged commit 062460a into wolfSSL:master Nov 3, 2022
yota22721 pushed a commit to yota22721/wolfssl-examples that referenced this pull request Jan 25, 2025
Use wolfSSL API functions; not private ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants