Skip to content

Use wolfSSL API functions; not private ones. #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 1 commit into from
Nov 3, 2022
Merged

Use wolfSSL API functions; not private ones. #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pq/sphincs_sign_verify.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ int main(int argc, char** argv)
}

if (ret == 0) {
InitDecodedCert(&decodedCert, cert_der_buf, cert_der_len, 0);
ret = ParseCert(&decodedCert, CERT_TYPE, NO_VERIFY, NULL);
wc_InitDecodedCert(&decodedCert, cert_der_buf, cert_der_len, 0);
Copy link
Copy Markdown
Member

@dgarske dgarske Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: These API's were added in wolfSSL/wolfssl#4645 and are in v5.1.0 or later.

Copy link
Copy Markdown
Member

@dgarske dgarske Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we had to use a macro to expose those private functions. The build macro can be found in asn.h. I can’t recall the name offhand.

Copy link
Copy Markdown
Member

@dgarske dgarske Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: https://github.com/wolfSSL/wolfssl/blob/e7a121325bbb51560cf954dec66cba069aa199af/wolfssl/wolfcrypt/asn.h#L1944

ret = wc_ParseCert(&decodedCert, CERT_TYPE, NO_VERIFY, NULL);
check_ret("ParseCert", ret);
}

Expand Down