Android: fix DEBUG_WOLFSSL in CMakeLists.txt, remove NO_FILESYSTEM#402
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Sep 29, 2023
Merged
Android: fix DEBUG_WOLFSSL in CMakeLists.txt, remove NO_FILESYSTEM#402JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
JacobBarthelmeh
approved these changes
Sep 29, 2023
yota22721
pushed a commit
to yota22721/wolfssl-examples
that referenced
this pull request
Jan 25, 2025
Android: fix DEBUG_WOLFSSL in CMakeLists.txt, remove NO_FILESYSTEM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
-DDEBUG_WOLFSSLdefine in the example Android Studio Gradle project for wolfssljni. The extraDwas left out of the define.It also adds
-DWOLFSSL_ANDROID_DEBUGby default, since this is an Android example and log output will need to go through logcat.Additionally, this removes
-DNO_FILESYSTEMfrom the example CMakeLists.txt since with recent versions of wolfSSL, the wolfCrypt test can properly use DH key buffers instead of files with the normal-DUSE_CERT_BUFFER_XXXdefines. wolfJSSE is also incompatible with-DNO_FILESYSTEM, so makes it easier not to accidentally leave it in a real application use.