Add refcounts on key, keyMask, altKey, altKeyMask to prevent UAF#10865
Closed
padelsbach wants to merge 5 commits into
Closed
Add refcounts on key, keyMask, altKey, altKeyMask to prevent UAF#10865padelsbach wants to merge 5 commits into
padelsbach wants to merge 5 commits into
Conversation
padelsbach
force-pushed
the
cert-alias-sni-uaf-pk
branch
from
ed5155d to
f8b4412
Compare
padelsbach
force-pushed
the
cert-alias-sni-uaf-pk
branch
from
f8b4412 to
160f72f
Compare
Contributor
Author
|
jenkins retest this please |
Contributor
Author
|
Will redesign a solution to prevent/block this scenario rather than try to fix it. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #10860. In this case, if the application replaces the private key file in the SNI callback (which frees and zeros the buffers) a subsequent sign operation would use stale or zeroed key.
This is a more impactful bug than in #10860. Fix is again to use refcounters on the fields.
Testing
Added unit test.
Checklist