Testing: AES GCM opps with IV < 96-bits now returns WC_FIPS_NOT_APPROVED with FIPS#10959
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the AES-GCM API test expectations to match new FIPS-module behavior where using an IV/nonce shorter than 96 bits is no longer an approved operation and returns WC_FIPS_NOT_APPROVED.
Changes:
- Adjusted
wc_AesGcmSetIV()test expectation forGCM_NONCE_MIN_SZto returnWC_FIPS_NOT_APPROVEDunder specific FIPS version conditions. - Preserved existing non-FIPS expectation (
0) for the same call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kaleb-himes
left a comment
There was a problem hiding this comment.
Merging after quick retest now that FIPS change is merged.
…tStatus_get and wc_Des3_SetKey.
9327bcf to
7b7ce70
Compare
|
FIPS-Ready PRB failures will require https://github.com/wolfSSL/fips/pull/408 |
|
Jenkins: retest this please Update FIPS testing |
|
./vectors-v2/KAS/req/KASValidityTest_FFCEphem_NOKC_ZZOnly_init.req |
@SparkiDev Looks like this was caused by disabling DH in the FIPS Ready build in b4a9326. It appears a fix will need another fips repo PR. Will link here if necessary |
|
Prerequisite for failing DH test: https://github.com/wolfSSL/fips/pull/409 |
Description
Accounts for the new functionality in https://github.com/wolfSSL/fips/pull/405 and needs the fixes in https://github.com/wolfSSL/fips/pull/407
Testing
./fips-check.sh ready keep
Checklist