Skip to content

Testing: AES GCM opps with IV < 96-bits now returns WC_FIPS_NOT_APPROVED with FIPS#10959

Merged
SparkiDev merged 3 commits into
wolfSSL:masterfrom
lealem47:WC_FIPS_NOT_APPROVED
Jul 22, 2026
Merged

Testing: AES GCM opps with IV < 96-bits now returns WC_FIPS_NOT_APPROVED with FIPS#10959
SparkiDev merged 3 commits into
wolfSSL:masterfrom
lealem47:WC_FIPS_NOT_APPROVED

Conversation

@lealem47

Copy link
Copy Markdown
Contributor

Description

Accounts for the new functionality in https://github.com/wolfSSL/fips/pull/405 and needs the fixes in https://github.com/wolfSSL/fips/pull/407

Testing

./fips-check.sh ready keep

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

Copilot AI review requested due to automatic review settings July 21, 2026 15:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AES-GCM API test expectations to match new FIPS-module behavior where using an IV/nonce shorter than 96 bits is no longer an approved operation and returns WC_FIPS_NOT_APPROVED.

Changes:

  • Adjusted wc_AesGcmSetIV() test expectation for GCM_NONCE_MIN_SZ to return WC_FIPS_NOT_APPROVED under specific FIPS version conditions.
  • Preserved existing non-FIPS expectation (0) for the same call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/api/test_aes.c Outdated
kaleb-himes
kaleb-himes previously approved these changes Jul 21, 2026

@kaleb-himes kaleb-himes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging after quick retest now that FIPS change is merged.

@lealem47

Copy link
Copy Markdown
Contributor Author

FIPS-Ready PRB failures will require https://github.com/wolfSSL/fips/pull/408

@SparkiDev

SparkiDev commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Jenkins: retest this please

Update FIPS testing

@SparkiDev

Copy link
Copy Markdown
Contributor

./vectors-v2/KAS/req/KASValidityTest_FFCEphem_NOKC_ZZOnly_init.req
Detected KAS FFC test, but DH not compiled in
RESULT of test harness was: 0
fips harness failed

@lealem47

Copy link
Copy Markdown
Contributor Author

./vectors-v2/KAS/req/KASValidityTest_FFCEphem_NOKC_ZZOnly_init.req Detected KAS FFC test, but DH not compiled in RESULT of test harness was: 0 fips harness failed

@SparkiDev Looks like this was caused by disabling DH in the FIPS Ready build in b4a9326. It appears a fix will need another fips repo PR. Will link here if necessary

@lealem47

Copy link
Copy Markdown
Contributor Author

Prerequisite for failing DH test: https://github.com/wolfSSL/fips/pull/409

@SparkiDev
SparkiDev merged commit f18ebef into wolfSSL:master Jul 22, 2026
329 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants