fix set_cipherlist edge case#6519
Closed
miyazakh wants to merge 2 commits intowolfSSL:masterfrom
Closed
Conversation
Contributor
Author
|
retest this please |
cconlon
requested changes
Sep 14, 2023
| suitesCpy = (byte*)XMALLOC(suites->suiteSz, NULL, DYNAMIC_TYPE_TMP_BUFFER); | ||
| if (suitesCpy == NULL) | ||
| return WOLFSSL_FAILURE; | ||
| if (suitesCpy == NULL) { |
Member
There was a problem hiding this comment.
This seems a little odd to me, that if suites->suiteSz is 0 that we would allocate suitesCpy to a size of 1.
Is this the correct way to handle this, or should we just be skipping the XMALLOC all together if suites->suiteSz is 0? Then adjusting logic inside this function to accomodate.
Contributor
Author
There was a problem hiding this comment.
That's true. I think that just skipping the XMALLOC when suites->suiteSz is zero is better than the logic here. will check that with CC-RX
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CC-RX malloc returns NULL when its size is zero. This causes wolfSSL_CTX_set_cipher_list failure in edge case.
./configure --enable-opensslextra --enable-smallstack
Testing
Run unit test case
Confirm the fix by CC-RX
Checklist