Support PKCS#7 definition for ContentType content ANY#6769
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Sep 14, 2023
Merged
Support PKCS#7 definition for ContentType content ANY#6769JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
…ition to CMS OCTET_STRING definition
Member
Author
|
Retest this please |
JacobBarthelmeh
approved these changes
Sep 14, 2023
Contributor
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Thanks Chris, tested it against the known bundle. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to wolfCrypt's PKCS#7 to support the older PKCS#7 RFC (RFC 2315) encoding of the SignedData ContentInfo content as
ANY. The newer CMS RFC (RFC 5652) defines that the content will be wrapped in anOCTET STRING, which our code was assuming would be the case.PKCS#7 RFC 2315 definition of SignedData ContentInfo:
CMS RFC 5652 definition of the same thing:
Related to ZD #16645.
Testing
Tested using customer PKCS#7 SignedData bundle, fed into wolfCrypt's PKCS#7 routines using the sample app being added to our
wolfssl-examplesrepository: wolfSSL/wolfssl-examples#400Checklist