Support for Public Key (PK) callbacks with PSK#7302
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Mar 13, 2024
Merged
Support for Public Key (PK) callbacks with PSK#7302JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
84b487e to
dfa2e30
Compare
….3 (client and server). ZD 17383
Member
Author
|
Retest this please |
JacobBarthelmeh
requested changes
Mar 11, 2024
Contributor
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
On Mac OS with latest wolfSSL master branch + this PR I see a failure with the unit tests:
I hear you fa shizzle!
starting psk cipher suite tests
starting TLS 1.3 psk no identity extra cipher suite tests
trying server command line[2007]: SuiteTest -v 4 -s -l TLS13-AES128-GCM-SHA256 -d -2 -p 0
trying client command line[2008]: SuiteTest -v 4 -s -l TLS13-AES128-GCM-SHA256 -2 -p 58037
PSK Server TLS 1.3 using HW (Len 32, Hint Client_identitySHA256)
SSL_accept error -333, psk key callback error
wolfSSL error: SSL_accept failed
wolfSSL_connect error -313, received alert fatal error
wolfSSL error: wolfSSL_connect failed
This is with doing:
./configure --enable-psk --enable-pkcallbacks CFLAGS="-DTEST_PK_PSK" && make
./tests/unit.test
Member
Author
Yes that is expected. The PK callback is not setup to inject a master secret, so this failure occurs. This work is being done for a customer's HSM. I understand if we need to hold off on merging until that is completed. |
JacobBarthelmeh
approved these changes
Mar 13, 2024
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Mar 15, 2024
…gth case. Thank you @miyazakh. Broken in wolfSSL#7302
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for Public Key (PK) callbacks with PSK in TLS v1.2 and TLS v1.3 (client and server).
Add support for returning
USE_HW_PSKfrom the PSK callbacks:wolfSSL_CTX_set_psk_server_callbackwolfSSL_CTX_set_psk_client_callbackwolfSSL_CTX_set_psk_server_tls13_callbackwolfSSL_CTX_set_psk_client_tls13_callbackFixes ZD 17383
Testing
Checklist