Fix for PSK callback with OPENSSL_EXTRA to correctly handle the 0 length#7341
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Mar 15, 2024
Merged
Fix for PSK callback with OPENSSL_EXTRA to correctly handle the 0 length#7341JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
…gth case. Thank you @miyazakh. Broken in wolfSSL#7302
JacobBarthelmeh
approved these changes
Mar 15, 2024
Contributor
|
Retest this please Jenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for PSK callback with OPENSSL_EXTRA to correctly handle the 0 length case. Thank you @miyazakh.
Broken in #7302
Hide: "I am seeing Qt Jenkins failure from couple days ago. I have dig into it. It starts after the PR7302 got merged. Qt uses PSK call back and it returns 0 if there is suitable data unavailable. In the case, it's TLS extensions didn’t have PSK extension, and it went TLS handshake. Now, it tries to set PSK extension when returning 0 from call back, and then becomes failure due to no available PSK when building PSK extension.
Testing
How did you test?
Checklist