RISC-V 64: Add assembly code for SHA-512#7833
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Aug 6, 2024
Merged
Conversation
dgarske
force-pushed
the
riscv-sha512-asm
branch
from
9043e5f to
0761a18
Compare
Member
|
I've rebased and force pushed to resolve the GitHub CI issues. Testing results: |
dgarske
previously approved these changes
Aug 5, 2024
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
SHA2-512 is 42% faster. Nice work! SHA2-256 is basically the same.
SparkiDev
force-pushed
the
riscv-sha512-asm
branch
2 times, most recently
from
ed32ec7 to
05a5dd2
Compare
Cleanup RISC-V 64 SHA-256 by removing unused rev_idx.
SparkiDev
force-pushed
the
riscv-sha512-asm
branch
from
05a5dd2 to
4062b94
Compare
Contributor
Author
|
Changed loading of W which should have improved things slightly. |
Member
|
Latest benchmarks for SHA2-512 are about 1% faster: I'll approve and merge. Thank you |
dgarske
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation of SHA-512 using RISC-V 64 instructions.
Cleanup RISC-V 64 SHA-256 by removing unused rev_idx.
Testing
./configure '--disable-shared' '--enable-sha384' '--enable-sha512' 'LDFLAGS=--static' '--host=riscv64' 'CC=riscv64-linux-gnu-gcc' '--enable-riscv-asm'
./configure '--disable-shared' '--enable-sha384' '--enable-sha512' 'LDFLAGS=--static' '--host=riscv64' 'CC=riscv64-linux-gnu-gcc' '--enable-riscv-asm=zbb'
./configure '--disable-shared' '--enable-sha384' '--enable-sha512' 'LDFLAGS=--static' '--host=riscv64' 'CC=riscv64-linux-gnu-gcc' '--enable-riscv-asm=zbb,zbkb'
./configure '--disable-shared' '--enable-sha384' '--enable-sha512' 'LDFLAGS=--static' '--host=riscv64' 'CC=riscv64-linux-gnu-gcc' '--enable-riscv-asm=zkn,zbb'
./configure '--disable-shared' '--enable-sha384' '--enable-sha512' 'LDFLAGS=--static' '--host=riscv64' 'CC=riscv64-linux-gnu-gcc' '--enable-riscv-asm=zkn,zbb,zbkb'
./configure '--disable-shared' '--enable-sha384' '--enable-sha512' 'LDFLAGS=--static' '--host=riscv64' 'CC=riscv64-linux-gnu-gcc' '--enable-riscv-asm=zvbb'
./configure '--disable-shared' '--enable-sha384' '--enable-sha512' 'LDFLAGS=--static' '--host=riscv64' 'CC=riscv64-linux-gnu-gcc' '--enable-riscv-asm=zvbb,zbb'
./configure '--disable-shared' '--enable-sha384' '--enable-sha512' 'LDFLAGS=--static' '--host=riscv64' 'CC=riscv64-linux-gnu-gcc' '--enable-riscv-asm=zvkned,zvbb'
Checklist