20241015-C89-pedantic-fixes#8077
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom Oct 16, 2024
Merged
Conversation
…macro to avoid -Wpedantics for "type of bit-field ... is a GCC extension", with overrideable default definition "byte", and replace parent types of all bitfields with WC_BITFIELD; fix numerous trailing commas in enums, mostly by removing them, but one (in asn.h, enum Extensions_Sum) using WOLF_ENUM_DUMMY_LAST_ELEMENT(); rearrange bitfields in struct ed25519_key for contiguity; always define WOLFSSL_SP_NO_DYN_STACK when defined(WOLF_C89).
SparkiDev
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean up wolfcrypt code base for
-std=c89 -pedantic: addWC_BITFIELDmacro to avoid-Wpedantics for "type of bit-field ... is a GCC extension", with overrideable default definitionbyte, and replace parent types of all bitfields withWC_BITFIELD;fix numerous trailing commas in
enums, mostly by removing them, but one (inasn.h,enum Extensions_Sum) usingWOLF_ENUM_DUMMY_LAST_ELEMENT();rearrange bitfields in
struct ed25519_keyfor contiguity;always define
WOLFSSL_SP_NO_DYN_STACKwhendefined(WOLF_C89).tested with
wolfssl-multi-test.sh ... allcryptonly-gcc-c89withallcryptonly-gcc-c89updated to test this configuration:also tested with
wolfssl-multi-test.sh ... super-quick-checkre ZD#18760