Fixes for "--enable-jni --enable-all" with WOLFSSL_TLS13_MIDDLEBOX_COMPAT#9404
Merged
dgarske merged 2 commits intowolfSSL:masterfrom Nov 11, 2025
Merged
Fixes for "--enable-jni --enable-all" with WOLFSSL_TLS13_MIDDLEBOX_COMPAT#9404dgarske merged 2 commits intowolfSSL:masterfrom
dgarske merged 2 commits intowolfSSL:masterfrom
Conversation
… compatible with WOLFSSL_TLS13_MIDDLEBOX_COMPAT
…COMPAT is defined
Member
Author
|
Retest this please Jenkins. PRB-CAVP-selftest-v2 (resume test). |
dgarske
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents
--enable-allfrom enabling QUIC and ECH when--enable-jniis also specified, as these are incompatible withWOLFSSL_TLS13_MIDDLEBOX_COMPATmode enabled by JNI. Changes include:configure.ac: Modified--enable-alllogic to exclude QUIC and ECH when$enable_jni = "yes"tests/api/test_tls13.c: Skiptest_tls13_hrr_different_cs()whenWOLFSSL_TLS13_MIDDLEBOX_COMPATis definedWithout these changes,
make checkfails with./configure --enable-jni --enable-all.QUIC incompatibility:
ECH incompatibility:
ClientHelloInner.legacy_session_idto be empty before encryptionGetTls13SessionId(), but simply skipping this test combo for now.Testing
Tested various enable combinations between the above with built-in tests.
Checklist