Skip to content

Fixes and Cleanup to SSLEngine Implementation#108

Merged
JacobBarthelmeh merged 7 commits intowolfSSL:masterfrom
cconlon:spring
Nov 23, 2022
Merged

Fixes and Cleanup to SSLEngine Implementation#108
JacobBarthelmeh merged 7 commits intowolfSSL:masterfrom
cconlon:spring

Conversation

@cconlon
Copy link
Copy Markdown
Member

@cconlon cconlon commented Oct 21, 2022

This PR makes fixes to wolfJSSE's SSLEngine implementation (WolfSSLEngine.java), including:

  • Set status to BUFFER_OVERFLOW when unwrap() needs more output buffer space
  • Fix for setting of client-side handshake FINISHED status
  • Fixes setting of output data across multiple output buffers
  • Fixes reported bytes consumed and produced
  • Set status to BUFFER_UNDERFLOW if the SSLEngine needs more data to proceed
  • Set the handshake status in SSLEngine.beginHandshake(), only initialize handshake once
  • Add synchronization lock around native WOLFSSL calls (read/write/connect/accept/etc)
  • Add extra synchronization tag on some additional functions

This PR also fixes a WolfSSLServerSocketTest which was failing after native wolfSSL updated an error code and string for a specific failure case.

These fixes were tested with reproducer applications from a support ticket which used Spring Boot (and Tomcat).

@cconlon cconlon marked this pull request as ready for review November 18, 2022 22:01
@cconlon cconlon self-assigned this Nov 18, 2022
@JacobBarthelmeh JacobBarthelmeh merged commit fd002c1 into wolfSSL:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants