Fixes and Cleanup to SSLEngine Implementation#108
Merged
JacobBarthelmeh merged 7 commits intowolfSSL:masterfrom Nov 23, 2022
Merged
Fixes and Cleanup to SSLEngine Implementation#108JacobBarthelmeh merged 7 commits intowolfSSL:masterfrom
JacobBarthelmeh merged 7 commits intowolfSSL:masterfrom
Conversation
…nsumed/produced reported
…fer space, fix client-side handshake FINISHED status
JacobBarthelmeh
approved these changes
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes fixes to wolfJSSE's SSLEngine implementation (WolfSSLEngine.java), including:
BUFFER_OVERFLOWwhen unwrap() needs more output buffer spaceBUFFER_UNDERFLOWif the SSLEngine needs more data to proceedThis PR also fixes a WolfSSLServerSocketTest which was failing after native wolfSSL updated an error code and string for a specific failure case.
These fixes were tested with reproducer applications from a support ticket which used Spring Boot (and Tomcat).