Skip to content

SSLSocket: change class variable InetSocketAddress to method local scope#113

Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
cconlon:sslSocketNullHost
Nov 23, 2022
Merged

SSLSocket: change class variable InetSocketAddress to method local scope#113
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
cconlon:sslSocketNullHost

Conversation

@cconlon
Copy link
Copy Markdown
Member

@cconlon cconlon commented Nov 23, 2022

This PR is a follow up to #111. The class variable InetSocketAddress address does not need to be a class variable inside WolfSSLSocket.java. It's only set and used locally within two connect() methods.

Copy link
Copy Markdown
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good refactor

@JacobBarthelmeh JacobBarthelmeh merged commit c7a8748 into wolfSSL:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants