Check TLS 1.3 session for ticket before saving to Java cache#175
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Feb 13, 2024
Merged
Conversation
JacobBarthelmeh
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes one change in native JNI code when getting and returning the native
WOLFSSL_SESSIONobject to be stored into the Java session cache.If the connection is using TLS 1.3, only return and store the session if we have the ticket. Otherwise, we may return an incomplete session object which may cause subsequent resumption attempts to fail.
This issue shows up in our ant tests when native wolfSSL is configured with: