Added check for legacy DHE keys (for cipher suites using keys less than 1024 bits)#243
Merged
cconlon merged 2 commits intowolfSSL:masterfrom Dec 23, 2024
Merged
Conversation
gasbytes
force-pushed
the
LegacyDHEKeyExchange-patch
branch
from
0f3046d to
20befbc
Compare
cconlon
requested changes
Dec 23, 2024
Member
cconlon
left a comment
cconlon
left a comment
There was a problem hiding this comment.
Looks good overall, just a few minor requests related to comment style and spacing
…per.java) and fixed identation (WolfSSLSocket.java)
gasbytes
force-pushed
the
LegacyDHEKeyExchange-patch
branch
from
94316d7 to
967f75e
Compare
cconlon
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added exception handling for
WolfSSLException, implementing key size checks for Diffie-Hellman (DH) key exchanges, and updating method signatures to reflect the new exception types.Tested running the testOSX.sh to make sure there were no tests regression after the changes.