Add X.509 Name Constraints extension support for certificate validation #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cconlon
force-pushed
the
nameConstraints
branch
2 times, most recently
from
18a8a4d to
4572d4e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cconlon
force-pushed
the
nameConstraints
branch
from
4572d4e to
eb63118
Compare
…fSSLNameConstraints, WolfSSLGeneralName
cconlon
force-pushed
the
nameConstraints
branch
from
eb63118 to
eec57b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
WolfSSLNameConstraintsandWolfSSLGeneralNameclasses to extract and validate X.509 Name Constraints extension (OID 2.5.29.30) from certificates. Includes JNI implementation wrapping native wolfSSLNAME_CONSTRAINTSstructure.WolfSSLNameConstraintsclass wrapping nativeWOLFSSL_NAME_CONSTRAINTSWolfSSLGeneralNameclass for GeneralName type/value pairsWolfSSLCertificate.getNameConstraints()to extract NC extensionWolfSSL.NameConstraintsEnabled()for feature detectionWraps new wolfSSL functionality introduced in wolfSSL/wolfssl#9705.
This new functionality relies on
WOLFSSL_VERSION_HEXto detect if native wolfSSL support will be available. Since native wolfSSL version hex is still matching last stable version (5.8.4), if building wolfssljni against master wolfssl, you will need to defineWOLFSSL_PR9705_PATCH_APPLIEDwhen running./java.sh: