Fix possible typecasting issues, typecast cleanup in native functions#98
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Feb 15, 2022
Merged
Conversation
JacobBarthelmeh
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few typecasting issues, cleans up native argument checking, and handles initial type casting of wolfSSL structure pointers up front in native functions before use or doing argument checking.
Most of this PR is cleanup as described above. Doing the structure pointer casting once on function enter will make it less likely casting issues will come up in the future. In some cases this also reduces the number of casts done in a single function.
This PR does fix runtime issues that can be seen on some platforms when the representation of a pointer stored in a jlong happens to be negative, but we check the value of it against "<= 0" before type casting it back to a structure pointer type.
For example, below is one bug that existed prior to this PR.
sslPtrwas being passed in from Java (wrapping a native pointer). Since jlong is a signed type, and we checkedsslPtr <= 0before casting back to a pointer, this could erroneously return SSL_FATAL_ERROR:This PR reworks this to move the type cast before the argument check: