fix: multidomain workbench navigation + close G009/G010 vNext review findings - #50
Merged
Merged
Conversation
Independent code-reviewer (APPROVE WITH NOTES) and architect (CLEAR WITH NOTES) passes over the vNext diff surfaced no invariant violations but several follow-ups; this fixes all of them: - surface server-recomputed findings/risk on the self-hosted pending-review read path so an approver no longer decides blind - fix a latent bug where receipt verification would reject every real self-hosted receipt once that path is wired up (approver === null assumed) - remove the zero-caller reviewCanSimulate() and document why the rest of the review lifecycle has coverage but no current production caller - drop the stale liveAvailable/provider/model fields from the app's /api/status (that's a CLI/server concern now, not the app route) - derive the self-hosted transport's domain-id enum from the durable review contract instead of hardcoding it twice - add /workbench/self-hosted to the client-bundle budget/asset sweep - extend the secret-canary scan from .js-only to .js/.mjs/.json/.map/.css plus emitted route HTML bodies - fix a misattributed-failure UI bug when a post-create queue refresh fails - remove a redundant double-parse in the analyze route - correct docs/FUTURE_DOMAIN_TEMPLATE.md and the docs/OSS_ROADMAP.md DurableReviewStore gap paragraph against this branch's actual code Full gate (lint, typecheck, builds, scenario checks, gallery) plus 1051 vitest and 31 Playwright tests all pass. Records G009/G010 closure evidence in the ultragoal plan doc. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…flow Codifies what this session learned the hard way: check for branch drift against origin/main before pushing, since parallel work can land the same feature under different commit SHAs, and a raw PR would otherwise show a misleading, unreviewable diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47b564462f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/superpowers/plans/2026-07-29-multidomain-console-vnext-ultragoal.md). Both stories were mostly already implemented; this PR is the verification pass plus fixes for everything the independent code-reviewer (APPROVE WITH NOTES) and architect (CLEAR WITH NOTES) gates surfaced:reviewCanSimulate()and documented the rest of that lifecycle's current-no-caller statusliveAvailable/provider/modelfields from the app's/api/status/workbench/self-hostedto the client-bundle budget/asset sweep.js-only to.js/.mjs/.json/.map/.cssplus emitted route HTML bodiesdocs/FUTURE_DOMAIN_TEMPLATE.mdand thedocs/OSS_ROADMAP.mdDurableReviewStoreparagraphRebased onto
origin/main(which already carries the vNext feature via #48/#49 under different commits) to keep this diff to genuinely new work only.Test plan
npm run lintnpm run typechecknpm run build:packages/npm run build:clinpm test— 1053 passed, 2 skippednpm run buildnpm run verify:client-bundlesscenario check(network/terraform/kubernetes, 13/13) +scenario gallery --checknpm run test:e2e— 31/31 passed🤖 Generated with Claude Code