fix(tests): repair CI critical-path Playwright failures on main - #65
Merged
Conversation
Three tests broke on main after PR #64 merged, each from a mismatch between an already-merged UI change and stale test expectations that predate this session's work: - The Terraform table's diff-inspect summary text grew to include the resource address ("Inspect values for module.boundary.aws_instance. worker_009"), which now substring-matches the same getByText query used for the address cell itself - a strict-mode violation. Scoped to exact: true. - An earlier commit added a pricing-engine Deployment to the shared Kubernetes snapshot (for the protected-resource-change fixture), taking the snapshot from 153 to 154 resources; the e2e assertion was never updated. - The self-hosted workbench's disabled three-pane shell was replaced by an explainer when no gateway is configured, but its e2e test still exercised the old interactive controls (select, disabled buttons) that no longer render in that state. Rewritten to assert the explainer's actual content instead. Verified by diffing against the pre-#64 commit (355a58d), where all three passed - confirming these are real regressions from that merge, not new breakage from anything in this fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainhas been red on the Playwright critical-paths job since PR #64 merged. Bisected against the pre-#64 commit (355a58d, which passes cleanly) and confirmed these are real regressions carried in by #64's diff, not flakiness:<summary>text grew toInspect values for module.boundary.aws_instance.worker_009, which now substring-matches the samegetByTextquery used for the address cell — a strict-mode violation (2 elements). Scoped the test locator toexact: true.pricing-engineDeployment to the shared snapshot (for the protected-resource-change fixture), moving the snapshot from 153 to 154 resources. The e2e assertion still hardcoded 153.Example artifactselect, disabled buttons) that no longer render in that state. Rewrote the test to assert the explainer's actual content.No product code changed — test-only fixes.
Test plan
npm run typechecknpm run lintnpm run test:e2e— 39/39 passedmain, and confirmed they do not reproduce on the pre-fix(app): close the UI/UX critique cycle across all four public workbenches #64 commit, isolating the regression to fix(app): close the UI/UX critique cycle across all four public workbenches #64's merged diff.🤖 Generated with Claude Code