[Scan to Update Inventory] Hide Scan Barcode Menu Item if store has Woo Square Plugin Active

[rossanafmenezes]

NOTE: This FluxC PR needs to be reviewed and merged first

Closes: #10266

Description

context: pdfdoF-47p-p2#comment-5261

This PR adds the logic to hide the Scan Barcode icon from the products list if the Woo Square plugin is active.

Testing instructions

• Use a store where the Woo Square plugin is installed and active
• Go to the product list
• Make sure the Scan Barcode icon in the menu bar is not being displayed
• Use a store without Woo Square
• Go to the products list
• Make sure the Scan Barcode icon is displayed in the menu.

Images/gif

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Flavor	Jalapeno
	Build Type	Debug
	Commit	3ebe432
	Direct Download	woocommerce-prototype-build-pr10279-3ebe432.apk

[codecov-commenter]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ba3fa2f) 41.74% compared to head (3ebe432) 41.74%.
Report is 9 commits behind head on trunk.

Files	Patch %	Lines
...mmerce/android/ui/products/ProductListViewModel.kt	42.85%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #10279      +/-   ##
============================================
- Coverage     41.74%   41.74%   -0.01%     
  Complexity     4885     4885              
============================================
  Files           993      993              
  Lines         55873    55879       +6     
  Branches       7410     7411       +1     
============================================
+ Hits          23322    23324       +2     
- Misses        30487    30491       +4     
  Partials       2064     2064              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[samiuelson]

Suggested change

	scanBarcodeMenuItem?.let { menuItem ->
	if (showScan) menuItem.isVisible else menuItem.isVisible = false
	}
	scanBarcodeMenuItem?.isVisible = !productListViewModel.isSquarePluginActive()

💡 Could we simplify the code like that?

[rossanafmenezes]

absolutely. Done here 3b4a772

[samiuelson]

LGTM

Just added small improvement idea

[wpmobilebot]

	1 Warning
⚠️	This PR is assigned to the milestone 16.6. The due date for this milestone has already passed. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger