Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Jul 2, 2024

Closes: #11867

Description

Adds animation and small code improvements to the home screen

Steps to reproduce

Testing information

  • Collect payment -> notice that payment success screen is full screen and has 1 card in it (not 2 as before)
  • Test other cases -> going back from there, new transactions and so on

Images/gif

07-02--11-14.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@kidinov kidinov added the feature: point of sale POS project label Jul 2, 2024
@kidinov kidinov added this to the 19.4 milestone Jul 2, 2024
@kidinov kidinov requested a review from backwardstruck July 2, 2024 09:20
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 2, 2024

3 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class Checkout is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ This PR is assigned to the milestone 19.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 2, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit86fc305
Direct Downloadwoocommerce-wear-prototype-build-pr11879-86fc305.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 2, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit86fc305
Direct Downloadwoocommerce-prototype-build-pr11879-86fc305.apk

@kidinov kidinov added unit-tests-exemption status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Jul 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 40.00%. Comparing base (0270d4e) to head (0b40c9d).

Files Patch % Lines
...erce/android/ui/woopos/home/WooPosHomeViewModel.kt 22.22% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                                       Coverage Diff                                                        @@
##             11714-woo-pos-show-only-small-part-of-the-cart-screen-when-there-are-not-products-selected   #11879      +/-   ##
================================================================================================================================
- Coverage                                                                                         40.00%   40.00%   -0.01%     
  Complexity                                                                                         5385     5385              
================================================================================================================================
  Files                                                                                              1165     1165              
  Lines                                                                                             66105    66113       +8     
  Branches                                                                                           9219     9221       +2     
================================================================================================================================
+ Hits                                                                                              26444    26446       +2     
- Misses                                                                                            37212    37217       +5     
- Partials                                                                                           2449     2450       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@backwardstruck backwardstruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code changes look good. I'll have it rebuild since it's not currently passing CI.

Screenshot_20240702_122042

@kidinov
Copy link
Contributor Author

kidinov commented Jul 3, 2024

@backwardstruck Thanks for the review!

I'll have it rebuild since it's not currently passing CI

It doesn't pass the CI because of the "do not merge" tag - to prevent from merging. You can click on the "details" next to the failed job to see why it didn't pass

Base automatically changed from 11714-woo-pos-show-only-small-part-of-the-cart-screen-when-there-are-not-products-selected to trunk July 3, 2024 17:26
@kidinov kidinov removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jul 4, 2024
@kidinov kidinov linked an issue Jul 4, 2024 that may be closed by this pull request
…ment-succeed

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/totals/payment/success/WooPosTotalsPaymentSuccessScreen.kt
@kidinov kidinov enabled auto-merge July 4, 2024 13:29
@kidinov kidinov merged commit 2fb0a68 into trunk Jul 4, 2024
@kidinov kidinov deleted the 11867-woo-pos-hide-cart-when-payment-succeed branch July 4, 2024 14:00
@backwardstruck
Copy link
Contributor

@backwardstruck Thanks for the review!

I'll have it rebuild since it's not currently passing CI

It doesn't pass the CI because of the "do not merge" tag - to prevent from merging. You can click on the "details" next to the failed job to see why it didn't pass

Indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Woo POS] Hide cart when payment succeed

6 participants