-
Notifications
You must be signed in to change notification settings - Fork 136
[Woo POS] Hide cart when payment succeed #11879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 11714-woo-pos-show-only-small-part-of-the-cart-screen-when-there-are-not-products-selected #11879 +/- ##
================================================================================================================================
- Coverage 40.00% 40.00% -0.01%
Complexity 5385 5385
================================================================================================================================
Files 1165 1165
Lines 66105 66113 +8
Branches 9219 9221 +2
================================================================================================================================
+ Hits 26444 26446 +2
- Misses 37212 37217 +5
- Partials 2449 2450 +1 ☔ View full report in Codecov by Sentry. |
backwardstruck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@backwardstruck Thanks for the review!
It doesn't pass the CI because of the "do not merge" tag - to prevent from merging. You can click on the "details" next to the failed job to see why it didn't pass |
…ment-succeed # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/totals/payment/success/WooPosTotalsPaymentSuccessScreen.kt
Indeed, thanks! |

Closes: #11867
Description
Adds animation and small code improvements to the home screen
Steps to reproduce
Testing information
Images/gif
07-02--11-14.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.