-
Notifications
You must be signed in to change notification settings - Fork 136
[Woo POS] M2: Update UI based on design for success screen #12165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] M2: Update UI based on design for success screen #12165
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #12165 +/- ##
=========================================
Coverage 39.95% 39.95%
Complexity 5572 5572
=========================================
Files 1213 1213
Lines 69208 69208
Branches 9695 9695
=========================================
Hits 27654 27654
Misses 38973 38973
Partials 2581 2581 ☔ View full report in Codecov by Sentry. |
|
FYI @samiuelson I updated this based on the meeting today. |
samiuelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| label = "cartOverlayAnimated" | ||
| ) | ||
|
|
||
| val totalsStartPaddingAnimatedDp by animateDpAsState( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in this commit. |
samiuelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
| modifier = Modifier.fillMaxSize(), | ||
| modifier = Modifier | ||
| .fillMaxSize() | ||
| .background(Color(0xFF98F179)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@backwardstruck I think we should not use hardcoded colors at this stage as it won't work in the dark mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I'll start adding them to the xml file instead.


Closes: #11828
Description
Make UI closer the M2 i2 design per this comment.
Steps to reproduce
Confirm UI looks more like the new designs. Button should be white though. Icons may be changed in the future so no need to check those.
Testing information
Images/gif
Should be close (OK if not 100% at this point) to the new design:
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.