Skip to content

Conversation

@backwardstruck
Copy link
Contributor

@backwardstruck backwardstruck commented Jul 29, 2024

Closes: #11828

Description

Make UI closer the M2 i2 design per this comment.

Steps to reproduce

  1. Go to POS
  2. Add a few products
  3. Checkout
  4. Complete the transaction

Confirm UI looks more like the new designs. Button should be white though. Icons may be changed in the future so no need to check those.

Testing information

Images/gif

Should be close (OK if not 100% at this point) to the new design:

Screenshot 2024-07-29 at 17 26 26
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@backwardstruck backwardstruck added this to the 19.8 milestone Jul 29, 2024
@backwardstruck backwardstruck changed the title [Woo POS] M2: Match design for success screen [Woo POS] M2: Update UI based on design for success screen Jul 29, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 29, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit336623b
Direct Downloadwoocommerce-wear-prototype-build-pr12165-336623b.apk

@backwardstruck backwardstruck marked this pull request as ready for review July 29, 2024 22:04
@backwardstruck backwardstruck added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jul 29, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 29, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit336623b
Direct Downloadwoocommerce-prototype-build-pr12165-336623b.apk

@backwardstruck backwardstruck removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jul 29, 2024
@backwardstruck backwardstruck enabled auto-merge July 29, 2024 22:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.95%. Comparing base (d9fc1c0) to head (336623b).

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #12165   +/-   ##
=========================================
  Coverage     39.95%   39.95%           
  Complexity     5572     5572           
=========================================
  Files          1213     1213           
  Lines         69208    69208           
  Branches       9695     9695           
=========================================
  Hits          27654    27654           
  Misses        38973    38973           
  Partials       2581     2581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backwardstruck backwardstruck disabled auto-merge July 31, 2024 12:20
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 31, 2024

1 Warning
⚠️ This PR is assigned to the milestone 19.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@backwardstruck backwardstruck marked this pull request as ready for review July 31, 2024 13:05
@backwardstruck
Copy link
Contributor Author

FYI @samiuelson I updated this based on the meeting today.

@samiuelson samiuelson self-assigned this Aug 1, 2024
Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I can see weird paddings at the sides of the screen though:
Screenshot_20240801_172906
I think it would be nice to remove these.

label = "cartOverlayAnimated"
)

val totalsStartPaddingAnimatedDp by animateDpAsState(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added here but as far as I can tell, we don't need it anymore. If that's not the case I will put it back. FYI @kidinov

@backwardstruck
Copy link
Contributor Author

Looks good overall. I can see weird paddings at the sides of the screen though: Screenshot_20240801_172906 I think it would be nice to remove these.

Fixed in this commit.

Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@samiuelson samiuelson merged commit acbccb7 into trunk Aug 2, 2024
@samiuelson samiuelson deleted the 11828-woo-pos-m2-match-design-for-success-screen branch August 2, 2024 09:04
modifier = Modifier.fillMaxSize(),
modifier = Modifier
.fillMaxSize()
.background(Color(0xFF98F179)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@backwardstruck I think we should not use hardcoded colors at this stage as it won't work in the dark mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll start adding them to the xml file instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Woo POS] M2: Update UI based on design for success screen

7 participants