Skip to content

Conversation

@ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Jul 24, 2024

Summary

Fix issue #12132, where authentication with an Application Password in the Wear app causes a crash. The fix, for now, consists of disabling the direct wear-to-store connection through FluxC when the Store is not connected through a bearer token and using the phone connection instead.

How to Test

  1. In the mobile app, authenticate with using an Application Password method through the Store credentials screen.
  2. Open the Wear app, make sure the sync starts, the store is loaded and all features are working as expected (Store stats, Orders list and Order details).

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 24, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit1722037
Direct Downloadwoocommerce-wear-prototype-build-pr12124-1722037.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 24, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit1722037
Direct Downloadwoocommerce-prototype-build-pr12124-1722037.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 39.99%. Comparing base (e7e9368) to head (1722037).

Files Patch % Lines
...ocommerce/android/wear/ui/login/LoginRepository.kt 0.00% 17 Missing ⚠️
...oocommerce/android/wear/system/ConnectionStatus.kt 0.00% 5 Missing ⚠️
...droid/wear/ui/orders/details/FetchOrderProducts.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #12124      +/-   ##
============================================
- Coverage     39.99%   39.99%   -0.01%     
  Complexity     5525     5525              
============================================
  Files          1200     1200              
  Lines         68416    68425       +9     
  Branches       9577     9580       +3     
============================================
  Hits          27364    27364              
- Misses        38492    38501       +9     
  Partials       2560     2560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomazFB ThomazFB marked this pull request as ready for review July 24, 2024 19:08
@ThomazFB ThomazFB merged commit 13e7c0f into trunk Jul 24, 2024
@ThomazFB ThomazFB deleted the issue/wear-handle-application-password-stores branch July 24, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wear App] Stores using Application Passwords fails the authentication sync

5 participants