[POS] Custom payment UI — Part 4 | Switching from viewStateData to paymentState

[samiuelson]

Switching from viewStateData to paymentState

Closes: #12825

Description

This PR:

1. Removes val viewStateData: LiveData<ViewState> from CardReaderPaymentController
2. Maps CardReaderPaymentController.paymentState to ViewState in CardReaderPaymentViewModel, using the CardReaderPaymentStateToViewStateMapper use case class

The goal of that PR is to make the payment controller independent of the ViewState class, and extract mapping of the CardReaderPaymentOrRefundState emitted by controller to ViewState (UI state of the existing IPP flow) in the target VM. Thanks to such separation, the controller will allow flexible reuse of the payment flow in the POS.

This is part 4 of 5 PRs refactoring the Payment flow:

1. [POS] Custom payment UI — Part 1 | Separating payment collection management from Android Framework
2. [POS] Custom payment UI — Part 2 | Separating CardReaderPaymentController's events from MultiLiveEvent
3. [POS] Custom Payment UI – Part 3 | Emitting UI–agnostic payment states in CardReaderPaymentController
4. [POS] Custom payment UI — Part 4 | Switch from viewStateData to paymentState
5. [POS] Custom payment UI — Part 5 | Unit tests clean up

⚠️ Don't merge — the branch will be merged together with the above ones after additional testing of the whole refactor.

Next steps

I'll add unit tests for CardReaderPaymentController, in the next PR.

Testing information

As a result of the refactoring done within this PR, the app should work without any change. It's crucial to test the IPP flow in the store management and POS modes against regression. It may be useful to base on the test plan (pdfdoF-5Jz-p2).

The tests that have been performed

• I tested the payment collection flow in both POS and store management modes, using card-present payment and TTP; verified that the IPP flow works and is not changed.

• I wasn't able to test Interac payments/refunds.

• The build from this PR will be used for call for testing – extra manual testing focused on regression.

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[dangermattic]

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	Class BuiltInReaderFailedPayment is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	9f747a8
	Direct Download	woocommerce-wear-prototype-build-pr12898-9f747a8.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	9f747a8
	Direct Download	woocommerce-prototype-build-pr12898-9f747a8.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 99.32660% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.16%. Comparing base (71e5b37) to head (9f747a8).
Report is 785 commits behind head on feature/custom-payment-ui.

Files with missing lines	Patch %	Lines
...payment/CardReaderPaymentStateToViewStateMapper.kt	99.47%	0 Missing and 1 partial ⚠️
.../payment/controller/CardReaderPaymentController.kt	93.33%	1 Missing ⚠️

Additional details and impacted files

@@                       Coverage Diff                       @@
##             feature/custom-payment-ui   #12898      +/-   ##
===============================================================
- Coverage                        40.65%   40.16%   -0.50%     
- Complexity                        5808     6073     +265     
===============================================================
  Files                             1251     1274      +23     
  Lines                            71210    73783    +2573     
  Branches                          9937    10089     +152     
===============================================================
+ Hits                             28952    29635     +683     
- Misses                           39624    41580    +1956     
+ Partials                          2634     2568      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[malinajirka]

Thanks @samiuelson ! Overall, it LGTM. I've left a couple questions. As with the previous PR, I just smoke tested the flow - I haven't ran thorough tests as I assume we'll run those anyway on the final PR of this chain of PRs.

[wpmobilebot]

Version 21.2 has now entered code-freeze, so the milestone of this PR has been updated to 21.3.