Skip to content

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Nov 21, 2024

Description

This only updates gems. The purpose is using the latest release-toolkit version.

Testing information

No need to test anything. The changes in the release-toolkit will be tested in another PR and it should affect only generating screenshots.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the Releases Used in release management. Using this label will skip some bot checks. label Nov 21, 2024
@irfano irfano added this to the 21.2 milestone Nov 21, 2024
@irfano irfano marked this pull request as ready for review November 21, 2024 17:44
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 21, 2024

1 Warning
⚠️ This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@irfano irfano added dependency update and removed Releases Used in release management. Using this label will skip some bot checks. labels Nov 21, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6dc1293
Direct Downloadwoocommerce-wear-prototype-build-pr12976-6dc1293.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6dc1293
Direct Downloadwoocommerce-prototype-build-pr12976-6dc1293.apk

@irfano irfano merged commit 695d513 into trunk Nov 21, 2024
20 of 21 checks passed
@irfano irfano deleted the update-ruby-gems branch November 21, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants