-
Notifications
You must be signed in to change notification settings - Fork 136
Connecting products #12981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connecting products #12981
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12981 +/- ##
=========================================
Coverage 40.24% 40.24%
- Complexity 6135 6140 +5
=========================================
Files 1283 1287 +4
Lines 74037 74136 +99
Branches 10138 10142 +4
=========================================
+ Hits 29795 29838 +43
- Misses 41656 41710 +54
- Partials 2586 2588 +2 ☔ View full report in Codecov by Sentry. |
ThomazFB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described, @atorresveiga! Nice solution taking advantage of the current Product repositories and great unit test coverage! 🚀
Part of: #12998
Description
This PR connects the product card with real data. To achieve this, the GetShippableItems use case is used to get valid shippable items, and the
WooShippingLabelCreationViewModelis updated to expose the results.I decided to include two different classes to represent shippable items:
ShippableItemModelandShippableItemUI. ShippableItemModel will be useful for calculating totals, split shipments, etc., while ShippableItemUI will be the UI representation of the product, including currency format and dimensions.Testing information
The tests that have been performed
Images/gif
Screen_recording_20241127_233702.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: