Skip to content

Enable configuration cache #12988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Enable configuration cache #12988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c8fcec
Enable configuration cache
wzieba Nov 22, 2024
b0e2ac2
Remove unused `printVersionName` task
wzieba Nov 22, 2024
ba218f3
Address deprecation of `String flavorDimensions`
wzieba Nov 22, 2024
37afcec
Remove `detektAutoCorrectPrompt` task
wzieba Nov 22, 2024
b27a044
Address `buildDir` deprecation, make `clean` task lazy
wzieba Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions WooCommerce/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ android {
coreLibraryDesugaringEnabled true
}

flavorDimensions "buildType"
flavorDimensions = ["buildType"]

productFlavors {
// Used for release/beta builds. Usually shouldn't be build locally.
Expand Down Expand Up @@ -552,12 +552,6 @@ android.buildTypes.all { buildType ->
}
}

task printVersionName {
doLast {
println android.defaultConfig.versionName
}
}

static def loadPropertiesFromFile(inputFile) {
def properties = new Properties()
inputFile.withInputStream { stream ->
Expand Down
21 changes: 3 additions & 18 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ subprojects {
}
}

def detektAll = tasks.register("detektAll", Detekt) {
tasks.register("detektAll", Detekt) {
description = "Custom DETEKT build for all modules"
parallel = true
ignoreFailures = false
Expand All @@ -101,27 +101,12 @@ def detektAll = tasks.register("detektAll", Detekt) {
}
}

def detektAutoCorrectPrompt = tasks.register("detektAutoCorrectPrompt") {
doLast {
def detektTask = detektAll.get()
if (detektTask.state.failure != null && !detektTask.autoCorrect) {
println ".-----------------------------------------------------------------------------------------------------------------------------------.\n" +
"| 🛠 Did you know: you can ask Detekt to automatically resolve some of the issues by running `./gradlew detektAll --auto-correct` |\n" +
"'-----------------------------------------------------------------------------------------------------------------------------------'"
}
}
}

detektAll.configure {
finalizedBy detektAutoCorrectPrompt
}

dependencies {
detektPlugins(libs.detekt.formatting)
}

task clean(type: Delete) {
delete rootProject.buildDir
tasks.register('clean', Delete) {
delete rootProject.layout.buildDirectory
}

/**
Expand Down
1 change: 1 addition & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ ksp.allow.all.target.configuration=false

# Enables Gradle Build Cache - https://docs.gradle.org/current/userguide/build_cache.html
org.gradle.caching=true
org.gradle.configuration-cache=true

android.useAndroidX=true
android.enableJetifier=false
Expand Down
Loading