Skip to content

Conversation

@atorresveiga
Copy link
Contributor

Part of: #12998

Description

This PR connects the shipping lines section inside the shipment details bottom sheet with real data (order's shipping lines).
To achieve this, I'm mapping the shipping lines from the order into ShippingLineSumary and exposing them to the view state.

Testing information

TC1

  1. Create an Order with the processing status on a store that can create shipping labels
  2. Tap on Orders
  3. Tap on the order created in step 1
  4. Add some shipping lines
  5. Tap on create shipping labels
  6. Expand the shipment details section
  7. Check that the shipping lines & items sections in the shipment details bottom sheet are accurate

TC2

  1. Create an Order with the processing status on a store that can create shipping labels
  2. Tap on Orders
  3. Tap on the order created in step 1
  4. Tap on create shipping labels
  5. Expand the shipment details section
  6. Check that the shipping lines & items sections in the shipment details bottom sheet are accurate (no shipping lines)

The tests that have been performed

Checking the UI works as expected

Images/gif

Screen_recording_20241128_203718.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Nov 28, 2024
@atorresveiga atorresveiga added this to the 21.3 milestone Nov 28, 2024
@atorresveiga atorresveiga mentioned this pull request Nov 28, 2024
5 tasks
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commite425df2
Direct Downloadwoocommerce-wear-prototype-build-pr13029-e425df2.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commite425df2
Direct Downloadwoocommerce-prototype-build-pr13029-e425df2.apk

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 37.83784% with 23 lines in your changes missing coverage. Please review.

Project coverage is 39.84%. Comparing base (fd6a6e7) to head (e425df2).
Report is 272 commits behind head on trunk.

Files with missing lines Patch % Lines
...oid/ui/orders/wooshippinglabels/ShipmentDetails.kt 4.16% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13029      +/-   ##
============================================
+ Coverage     39.75%   39.84%   +0.09%     
- Complexity     6049     6069      +20     
============================================
  Files          1278     1278              
  Lines         73584    73600      +16     
  Branches      10084    10084              
============================================
+ Hits          29250    29325      +75     
+ Misses        41753    41692      -61     
- Partials       2581     2583       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomazFB ThomazFB self-assigned this Nov 29, 2024
Base automatically changed from issue/12281-connecting-products to trunk November 29, 2024 20:29
Copy link
Contributor

@ThomazFB ThomazFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as described 🫡 Looks good!

@atorresveiga atorresveiga merged commit 509b9c9 into trunk Nov 29, 2024
18 of 20 checks passed
@atorresveiga atorresveiga deleted the issue/12998-connecting-shipping-lines branch November 29, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants