-
Notifications
You must be signed in to change notification settings - Fork 136
Shipping labels: Connecting addresses #13036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13036 +/- ##
============================================
- Coverage 40.49% 40.43% -0.06%
- Complexity 6188 6192 +4
============================================
Files 1287 1289 +2
Lines 74207 74394 +187
Branches 10156 10172 +16
============================================
+ Hits 30050 30082 +32
- Misses 41549 41703 +154
- Partials 2608 2609 +1 ☔ View full report in Codecov by Sentry. |
Parto of: #12998
Description
This PR supports connecting the ship to and ship from addresses to the creating shipping labels UI. To achieve this, I created the new model
OriginShippingAddressand introduced the new use caseObserveOriginAddresses. The new use case uses mock data with a delay to pretend the app is busy fetching the address data. Full address support is planned for M2, so I'm currently skipping testing for this new use case.I updated the
WooShippingLabelCreationViewModelto utilize the new use case and accurately represent the screen state with the order's information.Testing information
Before
TC1
*The ship from the section is operational but uses a different control to change the ship's address. Full support with the expected bottom sheet control will be added in M2.
TC2
TC3
The tests that have been performed
Images/gif
Screen_recording_20241209_203913.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: