-
Notifications
You must be signed in to change notification settings - Fork 136
Get origin address network #13211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get origin address network #13211
Conversation
…t-origin-address-network
…t-origin-address-network
…in-address-network
…t-origin-address-network
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
ThomazFB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice work with the use cases and data stores separations.
One thing I was thinking here and wanted to share in case it's useful for later: the ObserveStoreOptions and ObserveOriginAddresses are extremely similar in logic, only changing the data sources, but I'm not sure if there's a way to create a generic operation out of it or if it's worth to do so.
Closes: #12437
Description
This PR adds the logic to connect the origin addresses request response with the UI. To achieve this goal, I:
addressto group all the classes related to addressesTesting information
TC1
TC2
Patch
The tests that have been performed
Images/gif
Screen_recording_20241227_104206.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: