Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d1c8a32
Make ModalStatusBarBottomSheetLayout private and avoid its usage if A…
JorgeMucientes Jan 10, 2025
835fb94
Migrate any direct usages of ModalStatusBarBottomSheetLayout
JorgeMucientes Jan 10, 2025
f013afd
Place bottomsheet wrapping the whole screen
JorgeMucientes Jan 10, 2025
362f158
Cleanup ModalStatusBarBottomSheetLayout and suppress deprecation
JorgeMucientes Jan 10, 2025
3515ec6
Add missing import
JorgeMucientes Jan 10, 2025
01fb0a2
Add clearer name
JorgeMucientes Jan 10, 2025
961784e
Replace direct usages of ModalBottomSheetLayout
JorgeMucientes Jan 10, 2025
a5225ca
Fix detekt indentation issue
JorgeMucientes Jan 10, 2025
0d85128
Add back scrim color override to show consistent overlay in dark mode
JorgeMucientes Jan 10, 2025
2808770
Merge branch '13269-android-sdk-update-min-sdk-to-35' into 13269-andr…
kidinov Jan 14, 2025
fee48a2
Merge branch '13269-android-sdk-update-min-sdk-to-35' into 13269-andr…
kidinov Jan 14, 2025
62d2245
Merge branch '13269-android-sdk-update-min-sdk-to-35' into 13269-andr…
kidinov Jan 14, 2025
a3018fc
Merge branch '13269-android-sdk-update-min-sdk-to-35' into 13269-andr…
kidinov Jan 14, 2025
4b30575
Use system utils to check Android version
JorgeMucientes Jan 14, 2025
d58be6d
Fix typo
JorgeMucientes Jan 14, 2025
a3f0637
Remove ime nested scroll from bottomsheet modifier
JorgeMucientes Jan 14, 2025
76208b3
Fix bottomsheet for Blaze intro screen to show content edge to edge
JorgeMucientes Jan 14, 2025
5c5aed7
Moved imeNestedScroll to the specific bottom sheet that requires it
JorgeMucientes Jan 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import androidx.compose.material.ExperimentalMaterialApi
import androidx.compose.material.FloatingActionButton
import androidx.compose.material.Icon
import androidx.compose.material.MaterialTheme
import androidx.compose.material.ModalBottomSheetLayout
import androidx.compose.material.ModalBottomSheetValue
import androidx.compose.material.Text
import androidx.compose.material.icons.Icons.Filled
Expand Down Expand Up @@ -51,6 +50,7 @@ import com.woocommerce.android.ui.blaze.campaigs.BlazeCampaignListViewModel.Clic
import com.woocommerce.android.ui.compose.component.BottomSheetHandle
import com.woocommerce.android.ui.compose.component.InfiniteListHandler
import com.woocommerce.android.ui.compose.component.WCColoredButton
import com.woocommerce.android.ui.compose.component.WCModalBottomSheetLayout

@Composable
fun BlazeCampaignListScreen(viewModel: BlazeCampaignListViewModel) {
Expand Down Expand Up @@ -91,7 +91,7 @@ private fun BlazeCampaignListScreen(
}
}

ModalBottomSheetLayout(
WCModalBottomSheetLayout(
sheetState = bottomSheetState,
sheetContent = {
CampaignCelebrationSheet(onCampaignCelebrationDismissed)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,42 +115,42 @@ private fun CampaignBudgetScreen(
skipHalfExpanded = true,
)

Scaffold(
topBar = {
Toolbar(
onNavigationButtonClick = onBackPressed,
navigationIcon = Icons.AutoMirrored.Filled.ArrowBack
)
},
modifier = Modifier.background(MaterialTheme.colors.surface)
) { paddingValues ->
WCModalBottomSheetLayout(
sheetState = modalSheetState,
sheetContent = {
Column {
Spacer(modifier = Modifier.height(dimensionResource(id = dimen.minor_100)))
BottomSheetHandle(Modifier.align(Alignment.CenterHorizontally))
when {
state.showImpressionsBottomSheet -> ImpressionsInfoBottomSheet(
onDoneTapped = { coroutineScope.launch { modalSheetState.hide() } }
)
WCModalBottomSheetLayout(
sheetState = modalSheetState,
sheetContent = {
Column {
Spacer(modifier = Modifier.height(dimensionResource(id = dimen.minor_100)))
BottomSheetHandle(Modifier.align(Alignment.CenterHorizontally))
when {
state.showImpressionsBottomSheet -> ImpressionsInfoBottomSheet(
onDoneTapped = { coroutineScope.launch { modalSheetState.hide() } }
)

state.showCampaignDurationBottomSheet -> EditDurationBottomSheet(
budgetUiState = state,
onStartDateChanged = { onStartDateChanged(it) },
onApplyTapped = { duration, isEndlessCampaign, startDate ->
onApplyDurationTapped(duration, isEndlessCampaign, startDate)
coroutineScope.launch { modalSheetState.hide() }
},
onCancelTapped = { coroutineScope.launch { modalSheetState.hide() } },
onDurationSliderUpdated = { duration, startDate ->
onDurationSliderUpdated(duration, startDate)
}
)
}
state.showCampaignDurationBottomSheet -> EditDurationBottomSheet(
budgetUiState = state,
onStartDateChanged = { onStartDateChanged(it) },
onApplyTapped = { duration, isEndlessCampaign, startDate ->
onApplyDurationTapped(duration, isEndlessCampaign, startDate)
coroutineScope.launch { modalSheetState.hide() }
},
onCancelTapped = { coroutineScope.launch { modalSheetState.hide() } },
onDurationSliderUpdated = { duration, startDate ->
onDurationSliderUpdated(duration, startDate)
}
)
}
}
) {
}
) {
Scaffold(
topBar = {
Toolbar(
onNavigationButtonClick = onBackPressed,
navigationIcon = Icons.AutoMirrored.Filled.ArrowBack
)
},
modifier = Modifier.background(MaterialTheme.colors.surface)
) { paddingValues ->
Column(
modifier = Modifier
.padding(paddingValues)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ package com.woocommerce.android.ui.blaze.creation.destination
import androidx.activity.compose.BackHandler
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.ExperimentalLayoutApi
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.imeNestedScroll
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.shape.RoundedCornerShape
Expand All @@ -27,13 +29,13 @@ import com.woocommerce.android.R
import com.woocommerce.android.ui.blaze.creation.destination.BlazeCampaignCreationAdDestinationParametersViewModel.ViewState
import com.woocommerce.android.ui.blaze.creation.destination.BlazeCampaignCreationAdDestinationParametersViewModel.ViewState.ParameterBottomSheetState.Editing
import com.woocommerce.android.ui.compose.component.BottomSheetHandle
import com.woocommerce.android.ui.compose.component.ModalStatusBarBottomSheetLayout
import com.woocommerce.android.ui.compose.component.WCColoredButton
import com.woocommerce.android.ui.compose.component.WCModalBottomSheetLayout
import com.woocommerce.android.ui.compose.component.WCOutlinedTextField
import com.woocommerce.android.ui.compose.preview.LightDarkThemePreviews
import com.woocommerce.android.ui.compose.theme.WooThemeWithBackground

@OptIn(ExperimentalMaterialApi::class)
@OptIn(ExperimentalMaterialApi::class, ExperimentalLayoutApi::class)
@Composable
fun AdDestinationParametersBottomSheet(
viewState: ViewState,
Expand All @@ -56,7 +58,7 @@ fun AdDestinationParametersBottomSheet(
}
}

ModalStatusBarBottomSheetLayout(
WCModalBottomSheetLayout(
sheetState = modalSheetState,
sheetShape = RoundedCornerShape(topStart = roundedCornerRadius, topEnd = roundedCornerRadius),
sheetContent = {
Expand All @@ -65,10 +67,12 @@ fun AdDestinationParametersBottomSheet(
paramsState = viewState.bottomSheetState,
onParameterChanged = onParameterChanged,
onParameterSaved = onParameterSaved,
modifier = modifier.fillMaxWidth()
modifier = modifier
.fillMaxWidth()
)
}
}
},
modifier = Modifier.imeNestedScroll(),
) {
screenContent()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ import com.woocommerce.android.ui.compose.component.WCColoredButton
import com.woocommerce.android.ui.compose.component.WCModalBottomSheetLayout
import com.woocommerce.android.ui.compose.component.WCTextButton
import com.woocommerce.android.ui.compose.theme.WooThemeWithBackground
import kotlinx.coroutines.coroutineScope
import kotlinx.coroutines.launch

@Composable
Expand All @@ -78,41 +79,40 @@ fun BlazeCampaignCreationIntroScreen(
onDismissClick: () -> Unit,
onLearnMoreClick: () -> Unit,
) {
Scaffold(
topBar = {
Toolbar(
onNavigationButtonClick = onDismissClick,
navigationIcon = Icons.Default.Clear
val coroutineScope = rememberCoroutineScope()
val modalSheetState = rememberModalBottomSheetState(
initialValue = Hidden,
confirmValueChange = { it != HalfExpanded },
skipHalfExpanded = true
)

WCModalBottomSheetLayout(
sheetContent = {
BlazeCampaignBottomSheetContent(
onDismissClick = {
coroutineScope.launch { modalSheetState.hide() }
}
)
},
sheetState = modalSheetState,
modifier = Modifier.background(MaterialTheme.colors.surface)
) { paddingValues ->
val coroutineScope = rememberCoroutineScope()
val modalSheetState = rememberModalBottomSheetState(
initialValue = Hidden,
confirmValueChange = { it != HalfExpanded },
skipHalfExpanded = true
)

WCModalBottomSheetLayout(
sheetContent = {
BlazeCampaignBottomSheetContent(
onDismissClick = {
coroutineScope.launch { modalSheetState.hide() }
}
) {
Scaffold(
topBar = {
Toolbar(
onNavigationButtonClick = onDismissClick,
navigationIcon = Icons.Default.Clear
)
},
sheetState = modalSheetState,
modifier = Modifier
.background(MaterialTheme.colors.surface)
.padding(paddingValues)
) {
modifier = Modifier.background(MaterialTheme.colors.surface)
) { paddingValues ->
BlazeCampaignCreationIntroContent(
onContinueClick = onContinueClick,
onLearnMoreClick = {
coroutineScope.launch { modalSheetState.show() }
onLearnMoreClick()
}
},
modifier = Modifier.padding(paddingValues)
)
}
}
Expand Down

This file was deleted.

Loading
Loading