Skip to content

[Woo POS] Track POS-specific analytics event in case of reader payment flow cancellation #13333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025
Merged

[Woo POS] Track POS-specific analytics event in case of reader payment flow cancellation #13333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b37481
Implement mode-specific `CardReaderTrackCanceledFlowAction` instances
samiuelson Jan 16, 2025
cb16feb
Merge branch '13302-woo-pos-update-analytics-events-in-reader-payment…
samiuelson Jan 17, 2025
99913ad
Merge branch '13302-woo-pos-update-analytics-events-in-reader-payment…
samiuelson Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions WooCommerce/src/main/kotlin/com/woocommerce/android/di/AppModePaymentsFlowTrackingModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.woocommerce.android.di
import com.woocommerce.android.AppPrefsWrapper
import com.woocommerce.android.analytics.AnalyticsTrackerWrapper
import com.woocommerce.android.tools.SelectedSite
import com.woocommerce.android.ui.payments.cardreader.payment.controller.CardReaderTrackCanceledFlowAction
import com.woocommerce.android.ui.payments.receipt.PaymentReceiptHelper
import com.woocommerce.android.ui.payments.tracking.CardReaderTrackingInfoProvider
import com.woocommerce.android.ui.payments.tracking.PaymentsFlowTracker
Expand Down Expand Up @@ -70,6 +71,18 @@ class AppModePaymentsFlowTrackingModule {
paymentReceiptHelper = paymentReceiptHelper,
eventProvider = paymentsFlowTrackerEventProvider,
)

@Provides
@PointOfSaleMode
fun providePointOfSaleModeCardReaderTrackCanceledFlowAction(
@PointOfSaleMode tracker: PaymentsFlowTracker
): CardReaderTrackCanceledFlowAction = CardReaderTrackCanceledFlowAction(tracker)

@Provides
@StoreManagementMode
fun provideStoreManagementModeCardReaderTrackCanceledFlowAction(
@StoreManagementMode tracker: PaymentsFlowTracker
): CardReaderTrackCanceledFlowAction = CardReaderTrackCanceledFlowAction(tracker)
}

@Qualifier
Expand Down
2 changes: 1 addition & 1 deletion ...tlin/com/woocommerce/android/ui/payments/cardreader/payment/CardReaderPaymentViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class CardReaderPaymentViewModel @Inject constructor(
paymentCollectibilityChecker: CardReaderPaymentCollectibilityChecker,
interacRefundableChecker: CardReaderInteracRefundableChecker,
@StoreManagementMode tracker: PaymentsFlowTracker,
trackCancelledFlow: CardReaderTrackCanceledFlowAction,
@StoreManagementMode trackCancelledFlow: CardReaderTrackCanceledFlowAction,
currencyFormatter: CurrencyFormatter,
errorMapper: CardReaderPaymentErrorMapper,
interacRefundErrorMapper: CardReaderInteracRefundErrorMapper,
Expand Down
2 changes: 1 addition & 1 deletion ...com/woocommerce/android/ui/woopos/home/totals/WooPosCardReaderPaymentControllerFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class WooPosCardReaderPaymentControllerFactory @Inject constructor(
private val paymentCollectibilityChecker: CardReaderPaymentCollectibilityChecker,
private val interacRefundableChecker: CardReaderInteracRefundableChecker,
@PointOfSaleMode private val tracker: PaymentsFlowTracker,
private val trackCancelledFlow: CardReaderTrackCanceledFlowAction,
@PointOfSaleMode private val trackCancelledFlow: CardReaderTrackCanceledFlowAction,
private val currencyFormatter: CurrencyFormatter,
private val errorMapper: CardReaderPaymentErrorMapper,
private val interacRefundErrorMapper: CardReaderInteracRefundErrorMapper,
Expand Down
Loading