Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Feb 3, 2025

This PR is backport of wordpress-mobile/WordPress-FluxC-Android#3128

It doesn't include instrumentation/e2e tests changes as these tests weren't moved into woocommerce-android.

@wzieba wzieba requested a review from kidinov February 3, 2025 16:55
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6c62f8c
Direct Downloadwoocommerce-wear-prototype-build-pr13450-6c62f8c.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6c62f8c
Direct Downloadwoocommerce-prototype-build-pr13450-6c62f8c.apk

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 37.86%. Comparing base (bc699f8) to head (6c62f8c).
Report is 70 commits behind head on trunk.

Files with missing lines Patch % Lines
...wc/payments/inperson/InPersonPaymentsRestClient.kt 0.00% 23 Missing ⚠️
...yments/inperson/WCCapturePaymentResponsePayload.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13450      +/-   ##
============================================
- Coverage     37.87%   37.86%   -0.01%     
  Complexity     8947     8947              
============================================
  Files          2049     2049              
  Lines        112026   112045      +19     
  Branches      14170    14171       +1     
============================================
  Hits          42426    42426              
- Misses        65721    65740      +19     
  Partials       3879     3879              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzieba wzieba added type: enhancement A request for an enhancement. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Feb 3, 2025
@wzieba wzieba marked this pull request as ready for review February 3, 2025 17:39
Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @wzieba

@kidinov kidinov added this to the 21.7 milestone Feb 4, 2025
@wzieba wzieba merged commit 1328a2a into trunk Feb 4, 2025
19 checks passed
@wzieba wzieba deleted the backport_fluxc_3128 branch February 4, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants