Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Mar 17, 2025

Closes: #13781

Description

The PR make it visible that selection of products is disabled on the completed orders

Steps to reproduce

  • Open completed orders on a tablet
  • Notice that selection of the products looks like it's enabled

Testing information

  • Use tablet
  • Open both completed and not completed order
  • Notice that in completed selection of the products disabled and it's visible

The tests that have been performed

Above

Images/gif

03-17--16-00.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added the feature: order editing Related to unified order editing. label Mar 17, 2025
@kidinov kidinov added this to the 22.0 milestone Mar 17, 2025
@kidinov kidinov requested a review from samiuelson March 17, 2025 15:18
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 17, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitaa970c8
Direct Downloadwoocommerce-wear-prototype-build-pr13782-aa970c8.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 17, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitaa970c8
Direct Downloadwoocommerce-prototype-build-pr13782-aa970c8.apk

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 38.19%. Comparing base (267dd72) to head (aa970c8).
Report is 7 commits behind head on trunk.

Files with missing lines Patch % Lines
...i/products/selector/components/SelectorListItem.kt 0.00% 44 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13782      +/-   ##
============================================
- Coverage     38.20%   38.19%   -0.02%     
+ Complexity     9340     9339       -1     
============================================
  Files          2086     2086              
  Lines        115531   115560      +29     
  Branches      14735    14742       +7     
============================================
- Hits          44142    44141       -1     
- Misses        67372    67401      +29     
- Partials       4017     4018       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kidinov kidinov requested review from AnirudhBhat and removed request for samiuelson March 20, 2025 07:48
@wpmobilebot wpmobilebot modified the milestones: 22.0, 22.1 Mar 21, 2025
@wpmobilebot
Copy link
Collaborator

Version 22.0 has now entered code-freeze, so the milestone of this PR has been updated to 22.1.

…-search-results-when-editing-a-completed-order-but-it-looks-like-you-can
@AnirudhBhat AnirudhBhat self-assigned this Apr 1, 2025
Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. LGTM :shipit:

…-search-results-when-editing-a-completed-order-but-it-looks-like-you-can
@kidinov kidinov enabled auto-merge April 2, 2025 06:59
@kidinov kidinov merged commit e537b1e into trunk Apr 2, 2025
17 checks passed
@kidinov kidinov deleted the 13781-order-editing-cant-select-products-in-search-results-when-editing-a-completed-order-but-it-looks-like-you-can branch April 2, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: order editing Related to unified order editing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Order Editing] Can’t select products in search results when editing a completed order… but it looks like you can

5 participants