Skip to content

Conversation

@atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Mar 18, 2025

⚠️ This PR depends on this PR

Closes: #13396

Description

This PR fixes the edge-to-edge support for the MediaPickerActivity. The PR just updates the media picker library

Testing information

TC1

  1. Navigate to the products tab
  2. Open a product
  3. Tap on add new image
  4. Select WordPress media library
  5. Check that the app bar padding is displayed as expected

TC2

  1. Navigate to the products tab
  2. Open a product
  3. Tap on add new image
  4. Tap on Take a photo
  5. Check that the permission screen bar is displayed as expected

The tests that have been performed

Checking the Media Picker UI is displayed as expected

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added this to the 22.0 milestone Mar 18, 2025
@atorresveiga atorresveiga added type: enhancement A request for an enhancement. category: design Layout and style elements in the UI or user interface, including color and animations. Tech Debt labels Mar 18, 2025
@irfano irfano self-assigned this Mar 18, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 18, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitde8ba5c
Direct Downloadwoocommerce-wear-prototype-build-pr13785-de8ba5c.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 18, 2025

Project dependencies changes

list
! Upgraded Dependencies
org.wordpress.mediapicker:domain:trunk-0e275be05341678996dc1b9abfc8608f331d2540, (changed from 0.3.3)
org.wordpress.mediapicker:source-camera:trunk-0e275be05341678996dc1b9abfc8608f331d2540, (changed from 0.3.3)
org.wordpress.mediapicker:source-wordpress:trunk-0e275be05341678996dc1b9abfc8608f331d2540, (changed from 0.3.3)
org.wordpress:mediapicker:trunk-0e275be05341678996dc1b9abfc8608f331d2540, (changed from 0.3.3)
tree
-+--- org.wordpress:mediapicker:0.3.3
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
-|    +--- com.google.android.material:material:1.6.1 -> 1.12.0 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
-|    +--- androidx.fragment:fragment-ktx:1.5.4 -> 1.8.5 (*)
-|    +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
-|    +--- androidx.appcompat:appcompat:1.4.2 -> 1.6.1 (*)
-|    +--- androidx.constraintlayout:constraintlayout:2.1.4 (*)
-|    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 -> 2.8.7 (*)
-|    +--- androidx.datastore:datastore-preferences:1.0.0 (*)
-|    +--- com.github.bumptech.glide:glide:4.13.2 -> 4.16.0 (*)
-|    +--- com.google.dagger:hilt-android:2.55 (*)
-|    +--- com.github.chrisbanes:PhotoView:2.3.0 (*)
-|    +--- org.wordpress.mediapicker:domain:0.3.3
-|    |    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
-|    |    +--- androidx.annotation:annotation:1.6.0 -> 1.8.1 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
-|    +--- androidx.databinding:viewbinding:8.1.0 -> 8.8.0 (*)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
++--- org.wordpress:mediapicker:trunk-0e275be05341678996dc1b9abfc8608f331d2540
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
+|    +--- com.google.android.material:material:1.6.1 -> 1.12.0 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
+|    +--- androidx.fragment:fragment-ktx:1.5.4 -> 1.8.5 (*)
+|    +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
+|    +--- androidx.appcompat:appcompat:1.4.2 -> 1.6.1 (*)
+|    +--- androidx.constraintlayout:constraintlayout:2.1.4 (*)
+|    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 -> 2.8.7 (*)
+|    +--- androidx.datastore:datastore-preferences:1.0.0 (*)
+|    +--- com.github.bumptech.glide:glide:4.13.2 -> 4.16.0 (*)
+|    +--- com.google.dagger:hilt-android:2.55 (*)
+|    +--- com.github.chrisbanes:PhotoView:2.3.0 (*)
+|    +--- org.wordpress.mediapicker:domain:trunk-0e275be05341678996dc1b9abfc8608f331d2540
+|    |    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
+|    |    +--- androidx.annotation:annotation:1.6.0 -> 1.8.1 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
+|    +--- androidx.databinding:viewbinding:8.1.0 -> 8.8.0 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
-+--- org.wordpress.mediapicker:source-camera:0.3.3
-|    +--- org.wordpress.mediapicker:domain:0.3.3 (*)
-|    +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
++--- org.wordpress.mediapicker:source-camera:trunk-0e275be05341678996dc1b9abfc8608f331d2540
+|    +--- org.wordpress.mediapicker:domain:trunk-0e275be05341678996dc1b9abfc8608f331d2540 (*)
+|    +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
-\--- org.wordpress.mediapicker:source-wordpress:0.3.3
-     +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
-     +--- org.wordpress.mediapicker:domain:0.3.3 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
-     +--- com.google.dagger:hilt-android:2.55 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
+\--- org.wordpress.mediapicker:source-wordpress:trunk-0e275be05341678996dc1b9abfc8608f331d2540
+     +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
+     +--- org.wordpress.mediapicker:domain:trunk-0e275be05341678996dc1b9abfc8608f331d2540 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
+     +--- com.google.dagger:hilt-android:2.55 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)

Copy link
Contributor

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻 Tested on Android 10, Android 15 and tablet emulators. If you make changes to the library PR based on Andrei's comment, I can test this PR again.

Closes: #13396

This won't complete the issue since the issue still has open tasks. Let's change Closes: keyword to Part of:...

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 18, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitde8ba5c
Direct Downloadwoocommerce-prototype-build-pr13785-de8ba5c.apk

@atorresveiga
Copy link
Contributor Author

If you make changes to the library PR based on Andrei's comment, I can test this PR again.

Thanks for the review @irfano

I'm submitting some changes based on Andrei's comment. Let's wait for his feedback before merging this.

This won't complete the issue since the issue still has open tasks

Because the remaining task was related to the shipping labels project, I created a new issue for that so we can close this one. WDYT? (The issue is here)

@atorresveiga
Copy link
Contributor Author

Ready for another round @irfano

Copy link
Contributor

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again! It's working as expected! 👍🏻

@irfano irfano merged commit c5ae37b into 13270-android-sdk-update-target-sdk-to-35 Mar 19, 2025
16 checks passed
@irfano irfano deleted the issue/13396-edge-to-edge-media-picker branch March 19, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: design Layout and style elements in the UI or user interface, including color and animations. Tech Debt type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants