-
Notifications
You must be signed in to change notification settings - Fork 136
Edge to edge in media picker #13785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge to edge in media picker #13785
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Project dependencies changeslist! Upgraded Dependencies
org.wordpress.mediapicker:domain:trunk-0e275be05341678996dc1b9abfc8608f331d2540, (changed from 0.3.3)
org.wordpress.mediapicker:source-camera:trunk-0e275be05341678996dc1b9abfc8608f331d2540, (changed from 0.3.3)
org.wordpress.mediapicker:source-wordpress:trunk-0e275be05341678996dc1b9abfc8608f331d2540, (changed from 0.3.3)
org.wordpress:mediapicker:trunk-0e275be05341678996dc1b9abfc8608f331d2540, (changed from 0.3.3)tree-+--- org.wordpress:mediapicker:0.3.3
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
-| +--- com.google.android.material:material:1.6.1 -> 1.12.0 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
-| +--- androidx.fragment:fragment-ktx:1.5.4 -> 1.8.5 (*)
-| +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
-| +--- androidx.appcompat:appcompat:1.4.2 -> 1.6.1 (*)
-| +--- androidx.constraintlayout:constraintlayout:2.1.4 (*)
-| +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
-| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 -> 2.8.7 (*)
-| +--- androidx.datastore:datastore-preferences:1.0.0 (*)
-| +--- com.github.bumptech.glide:glide:4.13.2 -> 4.16.0 (*)
-| +--- com.google.dagger:hilt-android:2.55 (*)
-| +--- com.github.chrisbanes:PhotoView:2.3.0 (*)
-| +--- org.wordpress.mediapicker:domain:0.3.3
-| | +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
-| | +--- androidx.annotation:annotation:1.6.0 -> 1.8.1 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
-| +--- androidx.databinding:viewbinding:8.1.0 -> 8.8.0 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
++--- org.wordpress:mediapicker:trunk-0e275be05341678996dc1b9abfc8608f331d2540
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
+| +--- com.google.android.material:material:1.6.1 -> 1.12.0 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
+| +--- androidx.fragment:fragment-ktx:1.5.4 -> 1.8.5 (*)
+| +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
+| +--- androidx.appcompat:appcompat:1.4.2 -> 1.6.1 (*)
+| +--- androidx.constraintlayout:constraintlayout:2.1.4 (*)
+| +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
+| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 -> 2.8.7 (*)
+| +--- androidx.datastore:datastore-preferences:1.0.0 (*)
+| +--- com.github.bumptech.glide:glide:4.13.2 -> 4.16.0 (*)
+| +--- com.google.dagger:hilt-android:2.55 (*)
+| +--- com.github.chrisbanes:PhotoView:2.3.0 (*)
+| +--- org.wordpress.mediapicker:domain:trunk-0e275be05341678996dc1b9abfc8608f331d2540
+| | +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
+| | +--- androidx.annotation:annotation:1.6.0 -> 1.8.1 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
+| +--- androidx.databinding:viewbinding:8.1.0 -> 8.8.0 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
-+--- org.wordpress.mediapicker:source-camera:0.3.3
-| +--- org.wordpress.mediapicker:domain:0.3.3 (*)
-| +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
++--- org.wordpress.mediapicker:source-camera:trunk-0e275be05341678996dc1b9abfc8608f331d2540
+| +--- org.wordpress.mediapicker:domain:trunk-0e275be05341678996dc1b9abfc8608f331d2540 (*)
+| +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
-\--- org.wordpress.mediapicker:source-wordpress:0.3.3
- +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
- +--- org.wordpress.mediapicker:domain:0.3.3 (*)
- +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
- +--- com.google.dagger:hilt-android:2.55 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
+\--- org.wordpress.mediapicker:source-wordpress:trunk-0e275be05341678996dc1b9abfc8608f331d2540
+ +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.1.10 (*)
+ +--- org.wordpress.mediapicker:domain:trunk-0e275be05341678996dc1b9abfc8608f331d2540 (*)
+ +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
+ +--- com.google.dagger:hilt-android:2.55 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*) |
irfano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻 Tested on Android 10, Android 15 and tablet emulators. If you make changes to the library PR based on Andrei's comment, I can test this PR again.
Closes: #13396
This won't complete the issue since the issue still has open tasks. Let's change Closes: keyword to Part of:...
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Thanks for the review @irfano I'm submitting some changes based on Andrei's comment. Let's wait for his feedback before merging this.
Because the remaining task was related to the shipping labels project, I created a new issue for that so we can close this one. WDYT? (The issue is here) |
|
Ready for another round @irfano |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again! It's working as expected! 👍🏻
c5ae37b
into
13270-android-sdk-update-target-sdk-to-35
Closes: #13396
Description
This PR fixes the edge-to-edge support for the
MediaPickerActivity. The PR just updates the media picker libraryTesting information
TC1
TC2
The tests that have been performed
Checking the Media Picker UI is displayed as expected
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: