-
Notifications
You must be signed in to change notification settings - Fork 136
[WOOMOB-1258][Woo POS][Settings] Fix minor findings from the CFT #14557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOOMOB-1258][Woo POS][Settings] Fix minor findings from the CFT #14557
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14557 +/- ##
============================================
- Coverage 38.13% 38.13% -0.01%
Complexity 9520 9520
============================================
Files 2045 2045
Lines 114349 114352 +3
Branches 15152 15153 +1
============================================
Hits 43608 43608
- Misses 66746 66747 +1
- Partials 3995 3997 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samiuelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes several UI and consistency issues identified during the Woo POS settings CFT (Customer Feedback Testing). The changes focus on improving the store settings interface and maintaining consistency across different sections.
- Added email field to receipt information section to match store information
- Fixed address formatting inconsistency by adding comma-separated formatting for receipt addresses
- Updated loading states and help section titles for better consistency
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| WooPosSettingsStoreViewModelTest.kt | Added email field to test data for store information |
| strings.xml | Added new string resources for email label and help category title |
| WooPosSettingsStoreState.kt | Added email property to StoreInfo and ReceiptInfo data classes |
| WooPosSettingsStoreScreen.kt | Updated UI to display email field and improved loading state shimmer |
| WooPosSettingsReceiptRepository.kt | Added email field mapping and address formatting logic |
| WooPosSettingsCategoriesState.kt | Updated help category to use consistent string resource |
| WooPosSettingsState.kt | Updated help section title reference for consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| private fun formatReceiptAddress(address: String): String { | ||
| return address.replace("\n", ", ").replace(Regex(",\\s*,"), ",").trim() |
Copilot
AI
Sep 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex pattern for removing duplicate commas could be simplified. Consider using .replace(Regex(",+\\s*"), ", ") to handle multiple consecutive commas and whitespace more efficiently.
| return address.replace("\n", ", ").replace(Regex(",\\s*,"), ",").trim() | |
| return address.replace("\n", ", ").replace(Regex(",+\\s*"), ", ").trim() |
WOOMOB-1258
Description
Fixed several UI and consistency issues identified during the Woo POS settings CFT:
Steps to reproduce
Images/gif
09-03--14-50.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.