Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Sep 3, 2025

WOOMOB-1258

Description

Fixed several UI and consistency issues identified during the Woo POS settings CFT:

  • Added email field to receipt information in store settings
  • Fixed address formatting inconsistency between Store Information and Receipt Information sections
  • Updated receipt loading state to show section title while content is loading
  • Updated help section titles for consistency

Steps to reproduce

  1. Open the Woo POS app
  2. Navigate to Settings > Store
  3. Observe the Store Information and Receipt Information sections
  4. Check that email field appears after phone number
  5. Verify addresses are formatted consistently with commas
  6. Note that section title appears while receipt information is loading

Images/gif

09-03--14-50.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@kidinov kidinov changed the title [WOOMOB-1258] Fix minor findings from Woo POS settings CFT [WOOMOB-1258][Woo POS][Settings Fix minor findings from the CFT Sep 3, 2025
@kidinov kidinov added this to the 23.2 milestone Sep 3, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 3, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@kidinov kidinov requested a review from malinajirka September 3, 2025 12:53
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 3, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitba60a54
Direct Downloadwoocommerce-wear-prototype-build-pr14557-ba60a54.apk

@kidinov kidinov marked this pull request as ready for review September 3, 2025 13:07
@kidinov kidinov requested review from samiuelson and removed request for malinajirka September 3, 2025 13:07
@kidinov kidinov changed the title [WOOMOB-1258][Woo POS][Settings Fix minor findings from the CFT [WOOMOB-1258][Woo POS][Settings] Fix minor findings from the CFT Sep 3, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 3, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitba60a54
Direct Downloadwoocommerce-prototype-build-pr14557-ba60a54.apk

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.13%. Comparing base (2403aff) to head (ba60a54).
⚠️ Report is 32 commits behind head on trunk.

Files with missing lines Patch % Lines
.../android/ui/woopos/settings/WooPosSettingsState.kt 0.00% 1 Missing ⚠️
...ttings/categories/WooPosSettingsCategoriesState.kt 0.00% 1 Missing ⚠️
...s/details/store/WooPosSettingsReceiptRepository.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14557      +/-   ##
============================================
- Coverage     38.13%   38.13%   -0.01%     
  Complexity     9520     9520              
============================================
  Files          2045     2045              
  Lines        114349   114352       +3     
  Branches      15152    15153       +1     
============================================
  Hits          43608    43608              
- Misses        66746    66747       +1     
- Partials       3995     3997       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samiuelson samiuelson requested a review from Copilot September 4, 2025 14:36
Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samiuelson samiuelson merged commit 303cdcc into trunk Sep 4, 2025
17 checks passed
@samiuelson samiuelson deleted the woomob-1258-woo-possettings-fix-minor-findings-from-cft branch September 4, 2025 14:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several UI and consistency issues identified during the Woo POS settings CFT (Customer Feedback Testing). The changes focus on improving the store settings interface and maintaining consistency across different sections.

  • Added email field to receipt information section to match store information
  • Fixed address formatting inconsistency by adding comma-separated formatting for receipt addresses
  • Updated loading states and help section titles for better consistency

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
WooPosSettingsStoreViewModelTest.kt Added email field to test data for store information
strings.xml Added new string resources for email label and help category title
WooPosSettingsStoreState.kt Added email property to StoreInfo and ReceiptInfo data classes
WooPosSettingsStoreScreen.kt Updated UI to display email field and improved loading state shimmer
WooPosSettingsReceiptRepository.kt Added email field mapping and address formatting logic
WooPosSettingsCategoriesState.kt Updated help category to use consistent string resource
WooPosSettingsState.kt Updated help section title reference for consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}

private fun formatReceiptAddress(address: String): String {
return address.replace("\n", ", ").replace(Regex(",\\s*,"), ",").trim()
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern for removing duplicate commas could be simplified. Consider using .replace(Regex(",+\\s*"), ", ") to handle multiple consecutive commas and whitespace more efficiently.

Suggested change
return address.replace("\n", ", ").replace(Regex(",\\s*,"), ",").trim()
return address.replace("\n", ", ").replace(Regex(",+\\s*"), ", ").trim()

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants