-
Notifications
You must be signed in to change notification settings - Fork 136
Fix the incorrect size of the notification icon #14586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the incorrect size of the notification icon #14586
Conversation
The viewport dimensions are changed from 85.9x47.6 to 24x24.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
hichamboushaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks @irfano
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14586 +/- ##
=========================================
Coverage 38.42% 38.42%
Complexity 9738 9738
=========================================
Files 2059 2059
Lines 115359 115359
Branches 15357 15357
=========================================
Hits 44327 44327
Misses 66922 66922
Partials 4110 4110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes WOOMOB-727
Description
This fixes the incorrect layout of
ic_woo_w_notification.The correct icon size should be 24 × 24, with the content constrained to 20 × 20. Reference
Important
This is not a Wear app change. The notification icon comes from the phone app. Do not release a Wear version for this PR.
Layout of the new icon
Steps to reproduce
The tests that have been performed
Steps above.

Also tested the same icon in different places to ensure it isn’t broken.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.