Skip to content

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Sep 7, 2025

Closes WOOMOB-727

Description

This fixes the incorrect layout of ic_woo_w_notification.

The correct icon size should be 24 × 24, with the content constrained to 20 × 20. Reference

Important

This is not a Wear app change. The notification icon comes from the phone app. Do not release a Wear version for this PR.

Layout of the new icon

Screenshot 2025-09-07 at 14 23 19

Steps to reproduce

  1. This bug is not reproducible on API 36. Launch an API 35 phone emulator and an API 35 wear emulator.
  2. Install the Woo app on the phone.
  3. Log in to a store.
  4. Pair the watch with the phone.
  5. Allow notifications for both the Woo app and the “Google Pixel Watch” app.
  6. Ensure the Wear app is not muted or in Do Not Disturb mode.
  7. On the phone, search for “Special access” in Settings and allow “Wear OS by Google” to read, reply, and control notifications.
Screenshot_20250907_144304
  1. From the web, submit a product review as a customer.

The tests that have been performed

Steps above.
Also tested the same icon in different places to ensure it isn’t broken.
Screenshot 2025-09-07 at 14 54 07

Images/gif

Before After
image after
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

The viewport dimensions are changed from 85.9x47.6 to 24x24.
@irfano irfano added this to the 23.3 milestone Sep 7, 2025
@irfano irfano added feature: notifications Related to notifications or notifs. feature: android wear Bug labels Sep 7, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 7, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitea25b92
Direct Downloadwoocommerce-wear-prototype-build-pr14586-ea25b92.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 7, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitea25b92
Direct Downloadwoocommerce-prototype-build-pr14586-ea25b92.apk

@irfano irfano changed the title Update Woo notification icon Fix the incorrect size of the notification icon Sep 7, 2025
Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks @irfano

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.42%. Comparing base (c97c755) to head (ea25b92).
⚠️ Report is 5 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14586   +/-   ##
=========================================
  Coverage     38.42%   38.42%           
  Complexity     9738     9738           
=========================================
  Files          2059     2059           
  Lines        115359   115359           
  Branches      15357    15357           
=========================================
  Hits          44327    44327           
  Misses        66922    66922           
  Partials       4110     4110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hichamboushaba hichamboushaba merged commit 7aef481 into trunk Sep 15, 2025
17 checks passed
@hichamboushaba hichamboushaba deleted the issue/WOOMOB-727-fix-small-notification-icon-issue branch September 15, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants