Issue/woomob 1307 android bookings tab #14621
Conversation
This also includes a local feature flag to hide bookings tab while we work on the feature
Generated by 🚫 Danger |
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/BookingListFragment.kt
Fixed
Show fixed
Hide fixed
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
JorgeMucientes
added
category: tracks
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/tab/BookingsTabController.kt
Outdated
Show resolved
Hide resolved
| // Add here: Fetch if site has any published bookable product AND if site is CIAB | ||
| return@withContext Result.success(FeatureFlag.BOOKINGS_MVP.isEnabled()) |
There was a problem hiding this comment.
@JorgeMucientes Do you want to update this logic now, given there's new code in trunk to check for CIAB sites?
There was a problem hiding this comment.
Thanks for the suggestion. I'll address that as part of WOOMOB-1351
|
@JorgeMucientes I've noticed the events are not registered - I believe it's not a strong requirement, correct? |
Co-authored-by: Adam Grzybkowski <agrzybkowski@outlook.com>
Good catch. Actually, in a fairly recent conversation, it was decided that registering events is now mandatory p1749551598595309-slack-C03L1NF1EA3 So good reminder! I initiated registration here: |
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14621 +/- ##
============================================
- Coverage 38.50% 38.49% -0.02%
+ Complexity 9768 9767 -1
============================================
Files 2061 2064 +3
Lines 115396 115429 +33
Branches 15363 15370 +7
============================================
Hits 44430 44430
- Misses 66851 66883 +32
- Partials 4115 4116 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes WOOMOB-1350
Description
This PR adds a new Bookings tab to the bottom navigation bar:
BookingsTabControllerto check if bookings tabs should be shown when the app is resumed.This PR doesn't include:
BookingsTabControllerandShowBookingsTabthose will be added once the logic the missing logic fron the above 2 points is added.Testing information
debugmode and check a new Bookings tab is shownreleasemode and check the Bookings tab is not visibleThe tests that have been performed
The above ☝🏼
Images/gif
Screen_recording_20250916_202317.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.