-
Notifications
You must be signed in to change notification settings - Fork 136
Issue/woomob 1357 booking list fetch booking from api #14645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/woomob 1357 booking list fetch booking from api #14645
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
| "database": { | ||
| "version": 65, | ||
| "identityHash": "2d180f4d4c2ccaf6305a746959d1289d", | ||
| "identityHash": "2f88094bb00e637769cc5a8bdef5dcc3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JorgeMucientes I believe you accidentally commited a change to the schema file of the previous DB version, can you please revert it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch @hichamboushaba reverted changes applied to the 65.json schema.
hichamboushaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @JorgeMucientes, code looks good, and works as expected, but there is an issue with the modified schema of DB version 65.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14645 +/- ##
============================================
- Coverage 38.52% 38.48% -0.04%
Complexity 9783 9783
============================================
Files 2068 2072 +4
Lines 115558 115676 +118
Branches 15394 15400 +6
============================================
+ Hits 44522 44523 +1
- Misses 66899 67016 +117
Partials 4137 4137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
15d09ef to
ec944dd
Compare
|
FYI: I'm getting a crash when updating an already installed app (trunk) with the version from this branch. Fresh install works fine. |
hichamboushaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks @JorgeMucientes.
FYI: I'm getting a crash when updating an already installed app (trunk) with the version from this branch. Fresh install works fine.
@AdamGrzybkowski I think you tested before the last commit that reverted the changes to the schema of version 65, after the revert, the DB migration works without issues for me.
AdamGrzybkowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hichamboushaba You're right, I thought I pulled the latest changes...
@JorgeMucientes All good, sorry for the false alert!
Description
This PR adds a new rest client to fetch Bookings when opening the new Bookings tabs.
Testing information
v2on your CIAB testing site. You can do that by installing the Code Snippets plugin to your site and adding the following PHP snippet:define( 'WC_BOOKINGS_NEXT_ENABLED', true );/wp-json/wc-bookings/v2/bookings/?per_page=25&page=1[ { "id": 80, "start": 1759417200, "end": 1759420800, "all_day": false, "status": "unpaid", "cost": "30.00", "currency": "USD", "customer_id": 0, "product_id": 23, "resource_id": 22, "date_created": 1758531652, "date_modified": 1758531652, "google_calendar_event_id": "0", "order_id": 79, "order_item_id": 3, "parent_id": 0, "person_counts": [], "local_timezone": "", "_links": { ...wc-android-database-> BookingsThe tests that have been performed
The above ☝🏼
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.