Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Oct 14, 2025

WOOMOB-1475

Description

Changes the URLs to the real once

Also, fixed survey URL generation for Woo POS surveys by adding dedicated SurveyType enum entries. Previously, WooPOS survey URLs were passed as custom URLs without query parameters, causing 404 errors when additional tracking parameters were appended with & instead of ?.

The fix adds WOO_POS_POTENTIAL_USER and WOO_POS_CURRENT_USER to the SurveyType enum, ensuring all surveys follow the same URL construction pattern with proper query parameter handling.

Steps to reproduce

  1. Trigger a Woo POS survey notification (bot)
  2. Tap on the notification
  3. Verify the survey loads correctly
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 14, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@kidinov kidinov changed the base branch from trunk to woomob-1452-woo-possurveys-implement-a-click-on-the-notifications-to October 14, 2025 08:42
@kidinov kidinov changed the title [WOOMOB-1475] Fix Woo POS survey URL generation [WOOMOB-1475][Woo POS][Surveys] Woo POS Surveys realy URLs Oct 14, 2025
@kidinov kidinov added feature: POS category: tracks Related to analytics, including Tracks Events. labels Oct 14, 2025
@kidinov kidinov marked this pull request as ready for review October 14, 2025 08:46
@kidinov kidinov requested a review from malinajirka October 14, 2025 08:46
@kidinov kidinov added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Oct 14, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9529c3d
Direct Downloadwoocommerce-wear-prototype-build-pr14749-9529c3d.apk

@kidinov kidinov changed the title [WOOMOB-1475][Woo POS][Surveys] Woo POS Surveys realy URLs [WOOMOB-1475][Woo POS][Surveys] Woo POS Surveys real URLs. Fixed URL generation Oct 14, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9529c3d
Direct Downloadwoocommerce-prototype-build-pr14749-9529c3d.apk

@malinajirka malinajirka self-assigned this Oct 14, 2025
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from woomob-1452-woo-possurveys-implement-a-click-on-the-notifications-to to trunk October 15, 2025 08:08
@kidinov kidinov removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Oct 15, 2025
@kidinov kidinov enabled auto-merge October 15, 2025 09:27
@kidinov kidinov added this to the 23.5 milestone Oct 15, 2025
@kidinov kidinov merged commit 8b48ed1 into trunk Oct 15, 2025
30 checks passed
@kidinov kidinov deleted the woomob-1475-woo-possurveys-change-urls-on-the-actual-ones-when-available branch October 15, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events. feature: POS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants