[WOOMOB-1453] Booking details - refresh API call #14750

AdamGrzybkowski · 2025-10-14T10:01:52Z

Description

This PR implements the refresh logic on the Booking details screen.
It follows the Booking List logic - so first the booking is retrieved and then the corresponding order.

Additionally, I've added a basic error handling to show a snack when the call fails or when there's no network conneciton.

Steps to reproduce

Monitor network calls via Android Studio or any other tool you like
Launch the app
Go to bookings tab
Tap on the booking
Confirm two endpoints were made to fetch the booking and the order

Testing information

Repeat the above with disabled network.
Repeat the above with network but this time mock the API responses to fail.

The tests that have been performed

The above.

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Copilot

Pull Request Overview

This PR implements refresh functionality for the Booking details screen by adding API calls to fetch individual bookings and their associated orders. It follows the same pattern as the Booking List logic and includes basic error handling for network failures.

Key changes:

Added fetchBooking API endpoint and store method to retrieve individual bookings
Implemented refresh logic in BookingDetailsViewModel with network status checking
Added error handling with snackbar notifications for offline and API failure scenarios

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
libs/fluxc-processor/src/main/resources/wc-wp-api-endpoints.txt	Added individual booking endpoint pattern
libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/bookings/BookingsStore.kt	Implemented fetchBooking method with order fetching logic
libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/bookings/BookingsRestClient.kt	Added REST client method for individual booking fetch
WooCommerce/src/main/res/values/strings.xml	Added error message string for booking fetch failures
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsViewState.kt	Added loading state management for refresh functionality
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsViewModel.kt	Implemented refresh logic with network checking and error handling
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsFragment.kt	Added event handling for snackbar notifications
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/BookingsRepository.kt	Added repository method for booking fetch with error handling
WooCommerce/src/test/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsViewModelTest.kt	Added comprehensive test coverage for refresh functionality

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-14T10:02:23Z

WooCommerce/src/main/res/values/strings.xml

    <string name="booking_payment_label_service">Service</string>
    <string name="booking_payment_mark_as_paid">Mark as paid</string>
    <string name="booking_payment_view_order">View order</string>
+    <string name="booking_fetch_error">Error fetching booking</string>


Corrected string name from 'booking_fetch_error' to 'bookings_fetch_error' to match usage in code.

Suggested change

<string name="booking_fetch_error">Error fetching booking</string>

<string name="bookings_fetch_error">Error fetching booking</string>

wpmobilebot · 2025-10-14T10:11:03Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`e2ba38a`
	Direct Download	`woocommerce-wear-prototype-build-pr14750-e2ba38a.apk`

wpmobilebot · 2025-10-14T10:21:34Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`e2ba38a`
	Direct Download	`woocommerce-prototype-build-pr14750-e2ba38a.apk`

codecov-commenter · 2025-10-14T10:32:21Z

Codecov Report

❌ Patch coverage is 43.07692% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.36%. Comparing base (a4105ff) to head (e2ba38a).
⚠️ Report is 36 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...xc/network/rest/wpcom/wc/bookings/BookingsStore.kt	0.00%	18 Missing ⚠️
...twork/rest/wpcom/wc/bookings/BookingsRestClient.kt	0.00%	10 Missing ⚠️
...commerce/android/ui/bookings/BookingsRepository.kt	0.00%	7 Missing ⚠️
...oid/ui/bookings/details/BookingDetailsViewModel.kt	96.15%	0 Missing and 1 partial ⚠️
...oid/ui/bookings/details/BookingDetailsViewState.kt	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #14750   +/-   ##
=========================================
  Coverage     38.36%   38.36%           
- Complexity    10004    10006    +2     
=========================================
  Files          2115     2115           
  Lines        118014   118074   +60     
  Branches      15758    15766    +8     
=========================================
+ Hits          45280    45304   +24     
- Misses        68535    68570   +35     
- Partials       4199     4200    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hichamboushaba

Great work @AdamGrzybkowski, I left one comment about the endpoint we use for fetching orders.

And a remark here, I think adding support for pull-to-refresh would be beneficial here, as it would match the experience we have in order details, and also in case of failures, it will allow the user to retry, WDYT? This can be added in a separate PR.

hichamboushaba · 2025-10-14T11:34:14Z

.../src/main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/bookings/BookingsStore.kt

+                response.result != null -> {
+                    val dto = response.result
+                    val orderIds = listOf(dto.orderId).filterNot { it == 0L }
+                    val ordersResult = fetchOrders(site, orderIds)


This will use /wc/v3/orders?include=<orderId>, normally we should use /wc/v3/orders/<orderId> here, as there may be some performance benefits in using the single item endpoint.
To do this, we can use the function WCOrderStore#fetchSingleOrderSync, this returns the fetched order, and handles the caching too.

Good call, done in 5d68d50

hichamboushaba · 2025-10-14T11:51:42Z

...main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/bookings/BookingsRestClient.kt

+        val endpoint = WCWPAPIEndpoint(
+            WOOCOMMERCE.bookings.id(bookingId).endpoint
+        ).pathV2Bookings


I missed this in my review.

Suggested change

val endpoint = WCWPAPIEndpoint(

WOOCOMMERCE.bookings.id(bookingId).endpoint

).pathV2Bookings

val endpoint = WOOCOMMERCE.bookings.id(bookingId).pathV2Bookings

Done in 5d68d50

…oking_details_refresh

AdamGrzybkowski · 2025-10-14T12:53:50Z

@hichamboushaba Agree about the PTR - done here 45ff617

hichamboushaba

Thanks @AdamGrzybkowski for all the changes, nice work 👏

AdamGrzybkowski added 2 commits October 14, 2025 11:20

Refresh the booking object when entering the booking details screen

95f5078

Handle errors when refreshing booking on the details screen

d83afd9

AdamGrzybkowski added this to the 23.5 milestone Oct 14, 2025

AdamGrzybkowski requested review from Copilot and hichamboushaba October 14, 2025 10:01

AdamGrzybkowski added New Feature feature: CIAB Mobile Bookings MVP labels Oct 14, 2025

Copilot AI reviewed Oct 14, 2025

View reviewed changes

hichamboushaba self-assigned this Oct 14, 2025

hichamboushaba approved these changes Oct 14, 2025

View reviewed changes

hichamboushaba reviewed Oct 14, 2025

View reviewed changes

AdamGrzybkowski added 3 commits October 14, 2025 14:34

Merge remote-tracking branch 'origin/trunk' into issue/WOOMOB-1453_bo…

0259e0e

…oking_details_refresh

Use OrderStore.fetchSingleOrderSync to fetch single order

5d68d50

Implement pull to refresh in booking details

45ff617

AdamGrzybkowski requested a review from hichamboushaba October 14, 2025 12:53

Remove unnesary Surface from BookingDetailsScreen

e2ba38a

hichamboushaba approved these changes Oct 14, 2025

View reviewed changes

hichamboushaba merged commit 277fac2 into trunk Oct 14, 2025
16 checks passed

hichamboushaba deleted the issue/WOOMOB-1453_booking_details_refresh branch October 14, 2025 16:38

	<string name="booking_fetch_error">Error fetching booking</string>
	<string name="bookings_fetch_error">Error fetching booking</string>

[WOOMOB-1453] Booking details - refresh API call #14750

[WOOMOB-1453] Booking details - refresh API call #14750

Uh oh!

Conversation

AdamGrzybkowski commented Oct 14, 2025

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hichamboushaba left a comment

Choose a reason for hiding this comment

Uh oh!

hichamboushaba Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdamGrzybkowski Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

hichamboushaba Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

AdamGrzybkowski Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

AdamGrzybkowski commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hichamboushaba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wpmobilebot commented Oct 14, 2025 •

edited

Loading

wpmobilebot commented Oct 14, 2025 •

edited

Loading

codecov-commenter commented Oct 14, 2025 •

edited

Loading

hichamboushaba Oct 14, 2025 •

edited

Loading

AdamGrzybkowski commented Oct 14, 2025 •

edited

Loading