Skip to content

Conversation

@hichamboushaba
Copy link
Member

Closes WOOMOB-1554

Description

This PR handles the following changes:

  • Disables card reader support for CIAB sites.
  • Disables TTP support for CIAB sites.
  • Hides the In-Person Payments "learn more" button in the payment method selection screen.

Test Steps

  1. Use a phyiscal device (to confirm TTP logic)
  2. Open an existing order or create a new one.
  3. Tap on Collect Payment.
  4. Confirm that the unsupported options are hidden now.

Images/gif

Before After
Screenshot_20251026_123227 Screenshot_20251026_143226
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.


sealed class Result {
object Available : Result()
object Hidden : Result()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the Hidden option instead of creating a new one under NotAvailable because we already have logic in PaymentsHubTapToPayUnavailableHandler that displays information on why the feature isn't available. Since this logic is only used in the Payments hub, which we hide for CIAB sites, it was simpler to add the new top-level option, and not deal with adding a new branch in PaymentsHubTapToPayUnavailableHandler

enum class CIABAffectedFeature {
Blaze,
Payments,
WooPayments,
Copy link
Member Author

@hichamboushaba hichamboushaba Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this for clarity, Payments as a feature is still supported for CIAB sites, we just don't support features that rely on WooPayments (the Payments hub, IPP and TTP)

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commite0fdd12
Direct Downloadwoocommerce-wear-prototype-build-pr14828-e0fdd12.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commite0fdd12
Direct Downloadwoocommerce-prototype-build-pr14828-e0fdd12.apk

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.25%. Comparing base (c6c68cf) to head (e0fdd12).

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14828   +/-   ##
=========================================
  Coverage     38.24%   38.25%           
- Complexity    10088    10092    +4     
=========================================
  Files          2130     2130           
  Lines        120423   120431    +8     
  Branches      16490    16493    +3     
=========================================
+ Hits          46058    46066    +8     
+ Misses        69710    69709    -1     
- Partials       4655     4656    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hichamboushaba hichamboushaba marked this pull request as ready for review October 26, 2025 16:15
@AdamGrzybkowski AdamGrzybkowski self-assigned this Oct 27, 2025
Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great :shipit:

@hichamboushaba hichamboushaba added this to the 23.6 milestone Oct 27, 2025
@hichamboushaba hichamboushaba merged commit 1420231 into trunk Oct 27, 2025
23 checks passed
@hichamboushaba hichamboushaba deleted the issue/WOOMOB-1554-CIAB-hide-card-reader branch October 27, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants