-
Notifications
You must be signed in to change notification settings - Fork 136
[CIAB] Hide Card Reader and TTP options #14828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIAB] Hide Card Reader and TTP options #14828
Conversation
|
|
||
| sealed class Result { | ||
| object Available : Result() | ||
| object Hidden : Result() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included the Hidden option instead of creating a new one under NotAvailable because we already have logic in PaymentsHubTapToPayUnavailableHandler that displays information on why the feature isn't available. Since this logic is only used in the Payments hub, which we hide for CIAB sites, it was simpler to add the new top-level option, and not deal with adding a new branch in PaymentsHubTapToPayUnavailableHandler
| enum class CIABAffectedFeature { | ||
| Blaze, | ||
| Payments, | ||
| WooPayments, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed this for clarity, Payments as a feature is still supported for CIAB sites, we just don't support features that rely on WooPayments (the Payments hub, IPP and TTP)
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14828 +/- ##
=========================================
Coverage 38.24% 38.25%
- Complexity 10088 10092 +4
=========================================
Files 2130 2130
Lines 120423 120431 +8
Branches 16490 16493 +3
=========================================
+ Hits 46058 46066 +8
+ Misses 69710 69709 -1
- Partials 4655 4656 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdamGrzybkowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great ![]()
Closes WOOMOB-1554
Description
This PR handles the following changes:
Test Steps
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.