Skip to content

Conversation

@0nko
Copy link
Contributor

@0nko 0nko commented Nov 1, 2022

This PR adds some UX improvements for exiting the store creation flow:

  1. Tapping on the Back link on the first page of the survey exits the flow
  2. Tapping on the back button on the toolbar shows a confirmation dialog

To test:

  1. Start the store creation flow
  2. Tap on the Back link button on the page
  3. Notice the store creation flow is closed
  4. Start the store creation flow again
  5. Tap on the toolbar back navigation button
  6. Notice a confirmation dialog is show
  7. Tap OK and notice the creation flow is closed

@0nko 0nko added the feature: store creation Store creation flow label Nov 1, 2022
@0nko 0nko added this to the 11.1 milestone Nov 1, 2022
@0nko 0nko requested a review from JorgeMucientes November 1, 2022 16:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Base: 43.59% // Head: 43.57% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (59764b0) compared to base (ee35a8e).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 59764b0 differs from pull request most recent head 6eb4201. Consider uploading reports for the commit 6eb4201 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk    #7715      +/-   ##
============================================
- Coverage     43.59%   43.57%   -0.03%     
  Complexity     3441     3441              
============================================
  Files           623      623              
  Lines         34970    34989      +19     
  Branches       4537     4537              
============================================
  Hits          15245    15245              
- Misses        18325    18344      +19     
  Partials       1400     1400              
Impacted Files Coverage Δ
...ecreation/webview/WebViewStoreCreationViewModel.kt 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 1, 2022

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@JorgeMucientes JorgeMucientes self-assigned this Nov 1, 2022
@JorgeMucientes
Copy link
Contributor

Thanks for working on this @0nko. It works like a charm 👍🏼

One super minor np I noticed unrelated to these changes is that in line 53 from WebViewStoreCreationScreen you could use a function reference IconButton(onClick = viewModel::onBackPressed) like you did in line 47. You are welcome to ignore it and merge :)

@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@0nko 0nko enabled auto-merge November 2, 2022 08:59
@0nko 0nko merged commit bf37e14 into trunk Nov 3, 2022
@0nko 0nko deleted the feature/creation-flow-exit-improvements branch November 3, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: store creation Store creation flow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants